Skip to content

Commit

Permalink
[702] remove genome viewer links (#724)
Browse files Browse the repository at this point in the history
  • Loading branch information
justincorrigible committed Mar 22, 2021
1 parent 6097dab commit 0cacd78
Show file tree
Hide file tree
Showing 23 changed files with 49 additions and 640 deletions.
9 changes: 4 additions & 5 deletions dcc-portal-ui/UI.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ refer to the *package.json* file in the current directory to lookup which versio
* Please Refer to the Frontend *webpack.config.dev.js* and *webpack.config.prod.js* for More Details)
* SASS Preprocessor - CSS Development
* NPM and Yarn (Package Management)



### UI ###
Expand All @@ -62,7 +62,7 @@ refer to the *bower.json* file in the current directory to lookup which versions
### UI Architecture ###

The frontend UI is based fully on an AngularJS Single Page Application ([SPA](https://en.wikipedia.org/wiki/Single-page_application)) Architecture
meaning that the core domain logic is encapsulated on the server-side while the UI logic is soley handled in the user's browser and managed via JavaScript
meaning that the core domain logic is encapsulated on the server-side while the UI logic is soley handled in the user's browser and managed via JavaScript
(specifically [ECMAScript](https://en.wikipedia.org/wiki/ECMAScript) Version 5). Communication between the two layers is achieved using [RESTful](https://en.wikipedia.org/wiki/Representational_state_transfer) webservices.

![Image of Frontend Architecture](docs/images/architecture-diagram.png)
Expand All @@ -80,11 +80,10 @@ Folder | Purpose | Example
------ | --------- | -------
/scripts/404| 404 Page. It also redirects if the current page has been moved to a different URL. Configuration for this can be found in `/js/404.js` | [https://dcc.icgc.org/404](https://dcc.icgc.org/404)
/scripts/advanced| Advanced Page | [https://dcc.icgc.org/search](https://dcc.icgc.org/search)
/scripts/analysis | Set Analysis Page | [https://dcc.icgc.org/analysis](https://dcc.icgc.org/analysis)
/scripts/analysis | Set Analysis Page | [https://dcc.icgc.org/analysis](https://dcc.icgc.org/analysis)
**/scripts/app** | The main entry point in the application. This is the file that provides the definition of the main application module and it's dependencies.It also contains bootstrap code and some configuration for some of the dependencies (i.e. Restangular) used within the application. | N/A
/scripts/auth | Login module | N/A
/scripts/beacon | Global alliance beacon page | [https://dcc.icgc.org/ga4gh/beacon](https://dcc.icgc.org/ga4gh/beacon)
/scripts/browser | Genome Viewer Page | [https://dcc.icgc.org/browser](https://dcc.icgc.org/browser)
/scripts/common | Houses common angular services, filters, and other utilities that are shared among application modules. This is also the build area for the PQL grammar file. | N/A
/scripts/compounds | Drug Entity Page | [https://dcc.icgc.org/compound/ZINC000001530689](https://dcc.icgc.org/compound/ZINC000001530689)
/scripts/donors | Donor Page | N/A
Expand Down Expand Up @@ -333,4 +332,4 @@ in ```scripts/pancancer``` and ICGC Cloud pages which can be found in ```scripts
## Got Questions/Feeback? ##

* We are always happy to help - should you have any questions or feedback
please feel free to contact us at [[email protected]](mailto:[email protected])
please feel free to contact us at [[email protected]](mailto:[email protected])
5 changes: 1 addition & 4 deletions dcc-portal-ui/app/scripts/advanced/views/advanced.genes.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ <h3>
track('advanced-search-links', { action: 'click-enrichment' });
"><translate>Enrichment Analysis</translate></a>
</span>
<span class="action-item">
<i class="icon-chart"></i><a href="/browser/g?filters={{AdvancedCtrl.Location.filters()}}" ng-click="track('advanced-search-links', { action: 'click-genome-viewer' });"><translate>Genome Viewer</translate></a>
</span>
<span class="action-item">
<entityset-persistence-dropdown
selected-entity-ids="AdvancedCtrl.selectedEntityIdsMap.gene"
Expand Down Expand Up @@ -65,7 +62,7 @@ <h3>
data-tooltip-placement="left"><translate># Mutations</translate></abbr>
</th>
<th rowspan="2">
<abbr data-icgc-tooltip="{{ 'Cohort comparison for filtered donors with versus without mutated gene' | translate }}"
<abbr data-icgc-tooltip="{{ 'Cohort comparison for filtered donors with versus without mutated gene' | translate }}"
data-tooltip-placement="left"
style="display:block;">
<i class="icon-chart-bar">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
<h3>
<translate>Somatic Mutations</translate>
<span class="action-toolbar pull-right">
<span class="action-item">
<i class="icon-chart"></i>
<a href="/browser/m?filters={{AdvancedCtrl.Location.filters()}}">
<translate>Genome Viewer</translate>
</a>
</span>
<span class="action-item">
<entityset-persistence-dropdown selected-entity-ids="AdvancedCtrl.selectedEntityIdsMap.mutation" entity-type="'mutation'"
set-total-count="AdvancedCtrl.Mutation.mutations.pagination.total" set-limit="ICGC_SETTINGS.maxNumberOfHits"
Expand Down Expand Up @@ -178,4 +172,4 @@ <h3>
<td>{{mutation.uiDonorsExportString}}</td>
</tr>
</tbody>
</table>
</table>
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@ <h3 data-ng-if="AdvancedCtrl.Mutation.occurrences.hits.length == 0" class="empty
<translate>No Mutation Occurrences Found.</translate>
</h3>
<div data-ng-if="AdvancedCtrl.Mutation.occurrences.hits.length > 0">
<h3><translate>Mutation Occurrences</translate>
<span class="action-toolbar pull-right">
<i class="icon-chart"></i><a href="/browser/m?filters={{AdvancedCtrl.Location.filters()}}"><translate>Genome Viewer</translate></a>
</span>
</h3>
<h3><translate>Mutation Occurrences</translate></h3>

<div class="t_table_top">
<span data-table-counts data-label="{{'mutation occurrences' | translate}}"
Expand Down
2 changes: 0 additions & 2 deletions dcc-portal-ui/app/scripts/app/js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ var module = angular.module('icgc', [
'highcharts',

// modules
'icgc.modules.genomeviewer',
'proteinstructureviewer',

// core
Expand All @@ -223,7 +222,6 @@ var module = angular.module('icgc', [
'icgc.releases',
'icgc.portalfeature',
'icgc.keyword',
'icgc.browser',
'icgc.donorlist',
'icgc.genelist',
'icgc.entitySetUpload',
Expand Down
231 changes: 0 additions & 231 deletions dcc-portal-ui/app/scripts/browser/js/controller.js

This file was deleted.

41 changes: 0 additions & 41 deletions dcc-portal-ui/app/scripts/browser/js/routes.js

This file was deleted.

Loading

0 comments on commit 0cacd78

Please sign in to comment.