Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tile life from internal routines and BLAS routines #147

Merged
merged 12 commits into from
Dec 1, 2023
Merged

Remove tile life from internal routines and BLAS routines #147

merged 12 commits into from
Dec 1, 2023

Conversation

neil-lindquist
Copy link
Contributor

This addresses tile life in everywhere except 10 LAPACK routines. (N.B., #143 removes tile life from getrf, getrf_tntpiv, and getrf_nopiv, so it's really just 7 that are left.)

ayarkhan
ayarkhan reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@ayarkhan ayarkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some of the omp pragmas, we use slate_omp_default_none to ensure that all the data have the desired usage declared (e.g. firstprivate, shared). Is this something to continue? Adding all the variables usage does make the omp pragma awkward? Thoughts?

src/hemmA.cc Outdated Show resolved Hide resolved
src/svd.cc Show resolved Hide resolved
src/work/work_trmm.cc Show resolved Hide resolved
@neil-lindquist neil-lindquist mentioned this pull request Dec 1, 2023
Merged
@neil-lindquist neil-lindquist merged commit 68ab7f4 into icl-utk-edu:master Dec 1, 2023
8 checks passed
@neil-lindquist neil-lindquist deleted the blas-tile-life branch December 1, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayarkhan ayarkhan ayarkhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neil-lindquist @ayarkhan