Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gas fee and nonce errors, fix: ws disconnection #196

Merged
merged 4 commits into from
Apr 30, 2024
Merged

fix: gas fee and nonce errors, fix: ws disconnection #196

merged 4 commits into from
Apr 30, 2024

Conversation

debendraoli
Copy link
Collaborator

@debendraoli debendraoli commented Apr 30, 2024 •
edited
Loading

This pull request fixes gas fee and nonce errors by handling gas price and nonce mismatches.
fixes icon ws event disconnection by lowering the progressIntervel
Removes icon polling code.
It also upgrades go-ethereum to version 1.14.

@debendraoli debendraoli self-assigned this Apr 30, 2024
@debendraoli debendraoli changed the title Fix gas fee and nonce errors, upgrade go-ethereum to 1.14 fix: gas fee and nonce errors, fix: ws diconnection Apr 30, 2024
@debendraoli debendraoli changed the title fix: gas fee and nonce errors, fix: ws diconnection fix: gas fee and nonce errors, fix: ws disconnection Apr 30, 2024
AntonAndell
AntonAndell previously approved these changes Apr 30, 2024
View reviewed changes
Copy link

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we do seem to remove logic where we incremented gas previously. Was this created due to some issue with suggest gas or was it simply some other reason and suggest gas price should solve all issue?

@debendraoli
Copy link
Collaborator Author

LGTM, we do seem to remove logic where we incremented gas previously. Was this created due to some issue with suggest gas or was it simply some other reason and suggest gas price should solve all issue?

yeah, suggest gas price does solve all gas related issues.
That incremented value never seem to occur, eth_gasPrice always provides average gas price and increment is unnecessary.

@debendraoli debendraoli requested a review from AntonAndell April 30, 2024 05:22
@debendraoli debendraoli merged commit 3d811f6 into main Apr 30, 2024
4 of 5 checks passed
@debendraoli debendraoli deleted the fix/improvements branch April 30, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonAndell AntonAndell AntonAndell approved these changes

@bcsainju bcsainju Awaiting requested review from bcsainju

Assignees

@debendraoli debendraoli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debendraoli @AntonAndell