feat: stacks integration #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcsainju
reviewed
Nov 7, 2024
|
|
||
| func (c *Client) CallReadOnlyFunction(ctx context.Context, contractAddress string, contractName string, functionName string, functionArgs []string) (*string, error) { | ||
| fa := rpcClient.NewReadOnlyFunctionArgsschema( | ||
| "ST1PQHQKV0RJXZFY1DGX8MNSNYVE3VGZJSRTPGZGM", |
There was a problem hiding this comment.
typo or is the hardcoded address intentional ?
bcsainju
reviewed
Nov 7, 2024
| return address, nil | ||
| } | ||
|
|
||
| func (p *Provider) ImportKeystore(ctx context.Context, keyPath, passphrase string) (string, error) { |
There was a problem hiding this comment.
The import keystore is normally used to import keys generated using external commands may be wallets into the relayer. So, the input may be file generated by cli commands or private key which would not be encrypted with the kms.
bcsainju
reviewed
Nov 7, 2024
| case "stacks": | ||
| return stacks.ChainIDMainnet, nil | ||
| case "stacks_testnet": | ||
| return stacks.ChainIDTestnet, nil |
There was a problem hiding this comment.
We can directly configure required chainId in the nid so we would know this via config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #314, #315, #316, #317, #318, #319, #320