Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for tx confirmation in evm properly #464

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sherpalden
Copy link
Collaborator

@sherpalden sherpalden commented Dec 16, 2024

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@sherpalden sherpalden added bug Something isn't working EVM labels Dec 16, 2024
@sherpalden sherpalden self-assigned this Dec 16, 2024
MaximumPollTry = 15
DefaultCreateTimeout = time.Second * 10
DefaultTxConfirmationTimeout = time.Second * 45
DefaultCreateTimeout = time.Second * 10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this variable used anywhere ?

Copy link
Collaborator Author

@sherpalden sherpalden Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaximumPollTry is not used anymore anywhere. So, we can remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large default transaction polling time for waiting txn result in EVM chains
2 participants