Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

IS-828: Implement cancel transaction #24

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

IS-828: Implement cancel transaction #24

wants to merge 10 commits into from

Conversation

boyeon555
Copy link

  • Adds cancelTransaction API
  • Refactors code
  • Makes failed unit tests successful
  • Adds integration test for cancelTransaction

@boyeon555 boyeon555 self-assigned this Sep 20, 2019
@Spl3en
Copy link
Contributor

Spl3en commented Sep 20, 2019

Thanks a lot @boyeon555, awesome! 👍 😊

soobokjin
soobokjin reviewed Oct 24, 2019
View reviewed changes
multisig_wallet/multisig_wallet.py Outdated Show resolved Hide resolved
multisig_wallet/multisig_wallet.py Outdated Show resolved Hide resolved
multisig_wallet/multisig_wallet.py Outdated Show resolved Hide resolved
@boyeon555
Modify code reviews
60cc248 
- Converts '_check_valid_transaction' to '_check_transaction_exists'
- Modifies way to check unless transaction is None
soobokjin
soobokjin reviewed Oct 24, 2019
View reviewed changes
multisig_wallet/transaction.py Show resolved Hide resolved
multisig_wallet/multisig_wallet.py Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@soobokjin soobokjin soobokjin approved these changes

@goldworm-icon goldworm-icon Awaiting requested review from goldworm-icon

Assignees

@boyeon555 boyeon555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boyeon555 @Spl3en @soobokjin