Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cluster connection audit #424

Merged
merged 9 commits into from
Dec 13, 2024
Merged

fix: cluster connection audit #424

merged 9 commits into from
Dec 13, 2024

Conversation

sherpalden
Copy link
Contributor

@sherpalden sherpalden commented Dec 4, 2024

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@sherpalden sherpalden added bug Something isn't working enhancement New feature or request labels Dec 4, 2024
@sherpalden sherpalden self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.46%. Comparing base (8e26a88) to head (b53fabe).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...racts/evm/contracts/adapters/ClusterConnection.sol 90.90% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #424      +/-   ##
============================================
- Coverage     89.27%   87.46%   -1.82%     
  Complexity       77       77              
============================================
  Files            43        9      -34     
  Lines          2938     1037    -1901     
  Branches         37       37              
============================================
- Hits           2623      907    -1716     
+ Misses          298      113     -185     
  Partials         17       17              
Flag Coverage Δ
java 85.60% <ø> (ø)
rust ?
solidity 88.07% <90.90%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...racts/evm/contracts/adapters/ClusterConnection.sol 91.15% <90.90%> (+0.40%) ⬆️

... and 34 files with indirect coverage changes

@gcranju gcranju merged commit 04ccaa5 into main Dec 13, 2024
14 checks passed
@gcranju gcranju deleted the fix/cluster-connection-audit branch December 13, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants