Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reply removed from sendcallmessage and executerollback #67

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: reply removed from sendcallmessage and executerollback #67

merged 1 commit into from
Sep 6, 2023

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Sep 5, 2023

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@gcranju gcranju added enhancement New feature or request Audit Issue Cosmwasm Rust labels Sep 5, 2023
nightowl121
nightowl121 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@nightowl121 nightowl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@redlarva redlarva force-pushed the 264-xcall-reconsider-the-always-reply-condition branch from d863e41 to decbe92 Compare September 6, 2023 09:51
@redlarva redlarva force-pushed the 264-xcall-reconsider-the-always-reply-condition branch from decbe92 to 08ff6a9 Compare September 6, 2023 09:56
redlarva
redlarva approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@redlarva redlarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@redlarva redlarva merged commit c4750f5 into main Sep 6, 2023
8 checks passed
@redlarva redlarva deleted the 264-xcall-reconsider-the-always-reply-condition branch September 6, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightowl121 nightowl121 nightowl121 approved these changes

@redlarva redlarva redlarva approved these changes

@ibrizsabin ibrizsabin Awaiting requested review from ibrizsabin ibrizsabin is a code owner

@AntonAndell AntonAndell Awaiting requested review from AntonAndell AntonAndell is a code owner

Assignees
No one assigned
Labels
Audit Issue Cosmwasm Rust enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gcranju @redlarva @nightowl121