Prototype.js compatibility #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current versions of Magento (Community Edition, at least), Prototype messes with the Array prototype. As a result, the part of SVGInjector that copies attributes of the original `img` tag to the newly embedded SVG `tag`. The fix is manually iterating over the `img` tag's attributes instead of using `Array.filter()`, and adding the attributes matching the pattern to `imgData`.
|
✅ |
|
this is more of |
|
I agree. But since prototype.js' last release was in September 2015 I doubt they will fix anything. Also, fixing this in prototype.js is not backward compatible. The proposed change here on the other hand is completely transparent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
Array.prototype.filter()is overridden by prototype.js, changing the semantics of the call, which triggers an exception and essentially breaks SVGInjector on any site that uses at least version 1.7 of this library.A test case that breaks without the fix is included.
Since there are no contribution guidelines, I was not sure whether to do take the steps of the release procedure into this pull request. Please advise.