Updated neml to current dev #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, sigh. Yes, "neml_export.h" can just be #ifndef NEML_EXPORT_H #define NEML_EXPORT #endif (i.e. a bunch of null macros) for you but in the general case I need CMake to do the right thing and generate the correct Windows export magic words. Uhh, suggestions? |
|
So is neml_export.h generated by CMake? |
|
Yes
…On Mon, Nov 25, 2019, 17:51 Ben Spencer ***@***.***> wrote:
So is neml_export.h generated by CMake?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#84?email_source=notifications&email_token=ABZISQ4LRZTZOX47VNNGCY3QVRQJTA5CNFSM4JQW7AIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEGWBY#issuecomment-558394119>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZISQ55GRIWNEEWNIT3URTQVRQJTANCNFSM4JQW7AIA>
.
|
|
When we get to MOOSE builds on Windows our config system will have to
generate the right values for those macros and we will just create a static
neml_exports.h that proxies our macros.
…On Mon, Dec 30, 2019, 8:18 AM MOOSE Build ***@***.***> wrote:
Job App Test <https://civet.inl.gov/job/435571/> on 434a3c9
<434a3c9>
: invalidated by @bwspenc <https://github.com/bwspenc>
PR #85 <#85> should allow this
to build now
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#84?email_source=notifications&email_token=AABRMPRYLDX7ZIY4CVKSIMDQ3IGM3A5CNFSM4JQW7AIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH2QV2A#issuecomment-569707240>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRMPUENLW62SQAD6N7JBLQ3IGM3ANCNFSM4JQW7AIA>
.
|
|
Hmm... that didn't work for some reason. I'll look into this after we get back from the break on Jan 2. |
|
Taken care of by #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives you the new material models. Plus we made a lot of changes to CMake to make things work on Windows. We shall see how the MOOSE auto compile/testing handles that.
Closes #83