Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonlocal cracktip material #29576

Merged
merged 17 commits into from
Jan 21, 2025
Merged

Nonlocal cracktip material #29576

merged 17 commits into from
Jan 21, 2025

Conversation

lynnmunday
Copy link
Contributor

closes #29575

@moosebuild
Copy link
Contributor

moosebuild commented Dec 19, 2024 •
edited
Loading

Job Documentation, step Docs: sync website on 7dcf153 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Conda (Rocky) on 3740102 : invalidated by @lynnmunday

@moosebuild
Copy link
Contributor

Job OpenMPI on 3740102 : invalidated by @lynnmunday

@moosebuild
Copy link
Contributor

Job Test HPC on 3740102 : invalidated by @lynnmunday

@lynnmunday
Copy link
Contributor Author

@bwspenc Will you review?

@moosebuild
Copy link
Contributor

moosebuild commented Dec 20, 2024 •
edited
Loading

Job Coverage, step Generate coverage on 7dcf153 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Solid mechanics

b45164 #29576 7dcf15
Total Total +/- New
Rate 85.00% 85.01% +0.01% 91.84%
Hits 28504 28527 +23 90
Misses 5029 5031 +2 8

Diff coverage report

Full coverage report

Xfem

b45164 #29576 7dcf15
Total Total +/- New
Rate 82.38% 82.37% -0.01% 91.18%
Hits 6907 6916 +9 31
Misses 1477 1480 +3 3

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@lynnmunday lynnmunday marked this pull request as draft December 20, 2024 16:41
@lynnmunday lynnmunday marked this pull request as ready for review December 20, 2024 21:28
@lynnmunday lynnmunday force-pushed the nonlocal_cracktip_matl branch 2 times, most recently from 8da5e53 to 81f8043 Compare December 20, 2024 22:51
@lynnmunday
Fixing MeshCut2DFractureUserObject to use just stress based or consta…
22a9519 
…nt Kcrit or kcrit from vpp crack growth. Added error checking and testing for these options.
@lynnmunday lynnmunday force-pushed the nonlocal_cracktip_matl branch from 81f8043 to 22a9519 Compare December 23, 2024 17:18
@moosebuild
Copy link
Contributor

All jobs on 22a9519 : invalidated by @lynnmunday

bwspenc
bwspenc requested changes Dec 23, 2024
View reviewed changes
modules/solid_mechanics/doc/content/source/vectorpostprocessors/CrackFrontNonlocalScalar.md Outdated Show resolved Hide resolved
modules/solid_mechanics/doc/content/source/vectorpostprocessors/CrackFrontNonlocalScalar.md Outdated Show resolved Hide resolved
modules/solid_mechanics/doc/content/source/vectorpostprocessors/CrackFrontNonlocalStress.md Outdated Show resolved Hide resolved
modules/solid_mechanics/include/vectorpostprocessors/CrackFrontNonlocalMaterialBase.h Outdated Show resolved Hide resolved
modules/solid_mechanics/include/vectorpostprocessors/CrackFrontNonlocalStress.h Outdated Show resolved Hide resolved
modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalMaterialBase.C Outdated Show resolved Hide resolved
modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalMaterialBase.C Outdated Show resolved Hide resolved
modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalStress.C Outdated Show resolved Hide resolved
modules/xfem/src/userobjects/MeshCut2DFractureUserObject.C Outdated Show resolved Hide resolved
modules/xfem/test/tests/mesh_cut_2D_fracture/edge_crack_2d_propagation.i Outdated Show resolved Hide resolved
@moosebuild
Copy link
Contributor

Job OpenMPI on b9dfdc4 : invalidated by @lynnmunday

@lynnmunday
Copy link
Contributor Author

@dschwen and @bwspenc will you review and merge?

@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on d97a7fe wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/29576/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format b4516416a45e370aa097d9e3b4b4aac4cc17e2d3

@lynnmunday lynnmunday force-pushed the nonlocal_cracktip_matl branch from d97a7fe to 7dcf153 Compare January 15, 2025 19:11
@moosebuild
Copy link
Contributor

Job Conda build (Intel Mac) on 7dcf153 : invalidated by @lynnmunday

1 similar comment
@moosebuild
Copy link
Contributor

Job Conda build (Intel Mac) on 7dcf153 : invalidated by @lynnmunday

@moosebuild
Copy link
Contributor

Job OpenMPI on 7dcf153 : invalidated by @lynnmunday

@moosebuild
Copy link
Contributor

Job Clang min debug on 7dcf153 : invalidated by @lynnmunday

@moosebuild
Copy link
Contributor

Job OpenMPI on 7dcf153 : invalidated by @lynnmunday

1 similar comment
@moosebuild
Copy link
Contributor

Job OpenMPI on 7dcf153 : invalidated by @lynnmunday

@lynnmunday
Copy link
Contributor Author

@dschwen or @bwspenc
I can't get openMPI to pass. Can you review and merge. Its unrelated.

@moosebuild
Copy link
Contributor

Job OpenMPI on 7dcf153 : invalidated by @lynnmunday

@moosebuild
Copy link
Contributor

Job OpenMPI on 7dcf153 : invalidated by @lynnmunday

Test moose test -p 2; two failed: ERROR markers/expected_error.displaced_error ---------- FAILED (FILE TIMEOUT) FAIL markers/q_point_marker.test FAILED (CRASH)

@moosebuild
Copy link
Contributor

Job OpenMPI on 7dcf153 : invalidated by @lynnmunday

1 test fails; moose test -p 2 --distributed-mesh FAIL fvkernels/dispersion-test.top_right_limited_scalar_advection/sou FAILED (CRASH)

@moosebuild
Copy link
Contributor

Job OpenMPI on 7dcf153 : invalidated by @lynnmunday

1 test fails; moose test -p 2 --distributed-mesh FAIL quadrature/qweights.weights FAILED (CRASH)

@lynnmunday
Copy link
Contributor Author

@dschwen @bwspenc Will you review and merge. There is one unrelated failing test

@lynnmunday
Copy link
Contributor Author

This test now fails:
FAIL markers/value_range_marker.test_part1 FAILED (CRASH)

@bwspenc
Copy link
Contributor

bwspenc commented Jan 21, 2025

Merging with the following failed test because it is unrelated to this PR:
markers/value_range_marker.test_part1

@bwspenc bwspenc merged commit bf7a391 into idaholab:next Jan 21, 2025
50 of 51 checks passed
@GiudGiud GiudGiud mentioned this pull request Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschwen dschwen dschwen left review comments

@bwspenc bwspenc bwspenc approved these changes

@jiangwen84 jiangwen84 Awaiting requested review from jiangwen84 jiangwen84 is a code owner

Assignees

@bwspenc bwspenc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a vector postprocessor that can sample the materials at a crack front
4 participants
@lynnmunday @moosebuild @bwspenc @dschwen