Parameter groups and suppressions for a few systems #29608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppress isObjectAction which is not meant to be set by the user refs idaholab#29609
in very niche contexts (restart+stateful and name deconfliction refs idaholab#20535
|
Job Documentation, step Docs: sync website on 60d3e6b wanted to post the following: View the site here This comment will be updated on new commits. |
GiudGiud
force-pushed
the
PR_fixups
branch
4 times, most recently
from
070d8cd to
0686b46
Compare
|
Job Coverage, step Generate coverage on 60d3e6b wanted to post the following: Framework coverage
Modules coverageFluid properties
Solid properties
Thermal hydraulics
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Improve parameter groups for SIMPLE refs idaholab#29609
- fix math in AdamsPredictor - suppress matprop params in Times as unlikely to be used - add a param group for splits refs idaholab#20535
GiudGiud
requested review from
cticenhour,
joshuahansel,
lindsayad,
grmnptr,
roystgnr and
loganharbour
as code owners
joshuahansel
requested changes
Jan 9, 2025
fix typo Co-authored-by: joshuahansel <[email protected]>
|
thanks for the review! We'll need to wait for subchannel to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app patches (tick when merged)