Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SR2ML and logos submodule #1406

Merged
merged 5 commits into from
Jan 13, 2021
Merged

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Jan 12, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

see #1114

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05 wangcj05 requested a review from mandd January 12, 2021 22:40
@wangcj05
Copy link
Collaborator Author

@mandd This PR is ready for you to review.
@alfoa FYI. This PR will remove PRAplugin since SR2ML is now moved to GitHub repo.

@wangcj05 wangcj05 requested a review from alfoa January 13, 2021 02:26
@wangcj05 wangcj05 added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Jan 13, 2021
@wangcj05 wangcj05 changed the title update SR2ML and logos submodule WIP: update SR2ML and logos submodule Jan 13, 2021
@wangcj05 wangcj05 changed the title WIP: update SR2ML and logos submodule update SR2ML and logos submodule Jan 13, 2021
@alfoa
Copy link
Collaborator

alfoa commented Jan 13, 2021

PR Approved. The PRAPlugin has been moved from RAVEN to SR2ML. @wangcj05 @mandd you can merge it.

Please, can you send an email to the user-list informing about the new sub modules, the PRA Plugin (moved in the new submodule)? In addition, can you update the wiki?

@wangcj05
Copy link
Collaborator Author

The wiki is updated now.

@mandd
Copy link
Collaborator

mandd commented Jan 13, 2021

This PR is part of the transition from the PRAplugin contained in RAVEN to SR2ML github repository (see https://github.com/idaholab/SR2ML).
Board is green.
Merging

@mandd mandd merged commit e5c8b30 into devel Jan 13, 2021
@wangcj05 wangcj05 deleted the wangc/update_sr2ml_logos_submodule_id branch January 13, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants