Put egui in the demos behind a feature, so that it can be disabled wh… #212
clippy
122 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 122 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.76.0 (07dca489a 2024-02-04)
- cargo 1.76.0 (c84b36747 2024-01-18)
- clippy 0.1.76 (07dca48 2024-02-04)
Annotations
Check warning on line 62 in demos/src/moving_platform.rs
github-actions / clippy
associated function `make_system` is never used
warning: associated function `make_system` is never used
--> demos/src/moving_platform.rs:62:8
|
53 | impl MovingPlatform {
| ------------------- associated function in this implementation
...
62 | fn make_system<V: Component>(
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 210 in demos/src/ui/mod.rs
github-actions / clippy
unused variable: `setting_from_ui`
warning: unused variable: `setting_from_ui`
--> demos/src/ui/mod.rs:210:5
|
210 | setting_from_ui: Res<DemoUiPhysicsBackendActive>,
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_setting_from_ui`
Check warning on line 6 in demos/src/moving_platform.rs
github-actions / clippy
unused variable: `app`
warning: unused variable: `app`
--> demos/src/moving_platform.rs:6:21
|
6 | fn build(&self, app: &mut App) {
| ^^^ help: if this is intentional, prefix it with an underscore: `_app`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 296 in demos/src/bin/shooter_like.rs
github-actions / clippy
returning the result of a `let` binding from a block
warning: returning the result of a `let` binding from a block
--> demos/src/bin/shooter_like.rs:296:9
|
179 | / let command_altering_selectors = CommandAlteringSelectors::default()
180 | | // By default Tnua uses a raycast, but this could be a problem if the character stands
181 | | // just past the edge while part of its body is above the platform. To solve this, we
182 | | // need to cast a shape - which is physics-engine specific. We set the shape using a
... |
276 | | },
277 | | );
| |______________- unnecessary `let` binding
...
296 | command_altering_selectors
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
179 ~
180 | #[cfg(feature = "rapier3d")]
...
197 | );
198 ~ CommandAlteringSelectors::default()
199 + // By default Tnua uses a raycast, but this could be a problem if the character stands
200 + // just past the edge while part of its body is above the platform. To solve this, we
201 + // need to cast a shape - which is physics-engine specific. We set the shape using a
202 + // component.
203 + .with_combo(
204 + "Sensor Shape",
205 + 1,
206 + &[
207 + ("no", |mut cmd| {
208 + #[cfg(feature = "rapier3d")]
209 + cmd.remove::<TnuaRapier3dSensorShape>();
210 + #[cfg(feature = "xpbd3d")]
211 + cmd.remove::<TnuaXpbd3dSensorShape>();
212 + }),
213 + ("flat (underfit)", |mut cmd| {
214 + #[cfg(feature = "rapier3d")]
215 + cmd.insert(TnuaRapier3dSensorShape(rapier::Collider::cylinder(
216 + 0.0, 0.49,
217 + )));
218 + #[cfg(feature = "xpbd3d")]
219 + cmd.insert(TnuaXpbd3dSensorShape(xpbd::Collider::cylinder(0.0, 0.49)));
220 + }),
221 + ("flat (exact)", |mut cmd| {
222 + #[cfg(feature = "rapier3d")]
223 + cmd.insert(TnuaRapier3dSensorShape(rapier::Collider::cylinder(
224 + 0.0, 0.5,
225 + )));
226 + #[cfg(feature = "xpbd3d")]
227 + cmd.insert(TnuaXpbd3dSensorShape(xpbd::Collider::cylinder(0.0, 0.5)));
228 + }),
229 + ("flat (overfit)", |mut cmd| {
230 + #[cfg(feature = "rapier3d")]
231 + cmd.insert(TnuaRapier3dSensorShape(rapier::Collider::cylinder(
232 + 0.0, 0.51,
233 + )));
234 + #[cfg(feature = "xpbd3d")]
235 + cmd.insert(TnuaXpbd3dSensorShape(xpbd::Collider::cylinder(0.0, 0.51)));
236 + }),
237 + ("ball (underfit)", |mut cmd| {
238 + #[cfg(feature = "rapier3d")]
239 + cmd.insert(TnuaRapier3dSensorShape(rapier::Collider::ball(0.49)));
240 + #[cfg(feature = "xpbd3d")]
241 + cmd.insert(TnuaXpbd3dSensorShape(xpbd::Collider::ball(0.49)));
242 + }),
243 + ("ball (exact)", |mut cmd| {
244 + #[cfg(feature = "rapier3d")]
245 + cmd.insert(TnuaRapier3dSensorShape(rapier::Collider::ball(0.5)));
246 + #[cfg(feature = "xpbd3d")]
247 + cmd.insert(TnuaXpbd3dSensorShape(xpbd::Collider::ball(0.5)));
248 + }),
249 + ],
250 + )
251 + .with_checkbox("Lock Tilt", true, |mut cmd, lock_tilt| {
252 + // Tnua will automatically apply angular impulses/forces to fix the tilt and make
253 + // the character stand upward, but it is also possible to just let the physics
254 + // engine prevent rotation (other than around the Y axis, for turning)
255 + if lock_tilt {
256 + #[cfg(feature = "rapier3d")]
257 + cmd.insert(
258 + rapier::LockedAxes::ROTATION_LOCKED_X
259 + | rapier::LockedAxes::ROTATION_LOCKED_Z,
260 + );
261 + #[cfg(feature = "xpbd3d")]
262 + cmd.insert(xpbd::LockedAxes::new().lock_rotation_x().lock_rotation_z());
263 + } else {
264 + #[cfg(feature = "rapier3d")]
265 + cmd.insert(rapier::LockedAxes::empty());
266 + #[cfg(feature = "xpbd3d")]
267 + cmd.insert(xpbd::LockedAxes::new());
268 + }
269 + })
270 + .with_checkbox(
271 + "Phase Through Collision Groups",
272 + true,
273 + |mut cmd, use_collision_groups| {
274 + #[cfg(feature = "rapier3d")]
275 + if use_collision_groups {
276 + cmd.insert(CollisionGroups {
277 + memberships: Group::GROUP_2,
278 + filters: Group::GROUP_2,
279 + });
280 + } else {
281 + cmd.insert(CollisionGroups {
282 + memberships: Group::ALL,
283 + filters: Group::ALL,
284 + });
285 + }
286 + #[cfg(feature = "xpbd3d")]
287 + {
288 + let player_layers: &[LayerNames] = if use_collision_groups {
289 + &[LayerNames::Player]
290 + } else {
291 + &[LayerNames::Player, LayerNames::PhaseThrough]
292 + };
293 + cmd.insert(CollisionLayers::new(player_layers, player_layers));
294 + }
295 + },
296 + )
|
Check warning on line 254 in demos/src/bin/shooter_like.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> demos/src/bin/shooter_like.rs:254:18
|
254 | |mut cmd, use_collision_groups| {
| ----^^^
| |
| help: remove this `mut`
Check warning on line 232 in demos/src/bin/shooter_like.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> demos/src/bin/shooter_like.rs:232:48
|
232 | .with_checkbox("Lock Tilt", true, |mut cmd, lock_tilt| {
| ----^^^
| |
| help: remove this `mut`
Check warning on line 224 in demos/src/bin/shooter_like.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> demos/src/bin/shooter_like.rs:224:39
|
224 | ("ball (exact)", |mut cmd| {
| ----^^^
| |
| help: remove this `mut`
Check warning on line 218 in demos/src/bin/shooter_like.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> demos/src/bin/shooter_like.rs:218:42
|
218 | ("ball (underfit)", |mut cmd| {
| ----^^^
| |
| help: remove this `mut`
Check warning on line 210 in demos/src/bin/shooter_like.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> demos/src/bin/shooter_like.rs:210:41
|
210 | ("flat (overfit)", |mut cmd| {
| ----^^^
| |
| help: remove this `mut`
Check warning on line 202 in demos/src/bin/shooter_like.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> demos/src/bin/shooter_like.rs:202:39
|
202 | ("flat (exact)", |mut cmd| {
| ----^^^
| |
| help: remove this `mut`
Check warning on line 194 in demos/src/bin/shooter_like.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> demos/src/bin/shooter_like.rs:194:42
|
194 | ("flat (underfit)", |mut cmd| {
| ----^^^
| |
| help: remove this `mut`
Check warning on line 188 in demos/src/bin/shooter_like.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> demos/src/bin/shooter_like.rs:188:29
|
188 | ("no", |mut cmd| {
| ----^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
Check warning on line 300 in demos/src/bin/shooter_like.rs
github-actions / clippy
unused variable: `cmd`
warning: unused variable: `cmd`
--> demos/src/bin/shooter_like.rs:300:56
|
300 | cmd.insert(TnuaCrouchEnforcer::new(0.5 * Vec3::Y, |cmd| {
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
Check warning on line 254 in demos/src/bin/shooter_like.rs
github-actions / clippy
unused variable: `use_collision_groups`
warning: unused variable: `use_collision_groups`
--> demos/src/bin/shooter_like.rs:254:27
|
254 | |mut cmd, use_collision_groups| {
| ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_use_collision_groups`
Check warning on line 254 in demos/src/bin/shooter_like.rs
github-actions / clippy
unused variable: `cmd`
warning: unused variable: `cmd`
--> demos/src/bin/shooter_like.rs:254:22
|
254 | |mut cmd, use_collision_groups| {
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
Check warning on line 232 in demos/src/bin/shooter_like.rs
github-actions / clippy
unused variable: `cmd`
warning: unused variable: `cmd`
--> demos/src/bin/shooter_like.rs:232:52
|
232 | .with_checkbox("Lock Tilt", true, |mut cmd, lock_tilt| {
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
Check warning on line 224 in demos/src/bin/shooter_like.rs
github-actions / clippy
unused variable: `cmd`
warning: unused variable: `cmd`
--> demos/src/bin/shooter_like.rs:224:43
|
224 | ("ball (exact)", |mut cmd| {
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
Check warning on line 218 in demos/src/bin/shooter_like.rs
github-actions / clippy
unused variable: `cmd`
warning: unused variable: `cmd`
--> demos/src/bin/shooter_like.rs:218:46
|
218 | ("ball (underfit)", |mut cmd| {
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
Check warning on line 210 in demos/src/bin/shooter_like.rs
github-actions / clippy
unused variable: `cmd`
warning: unused variable: `cmd`
--> demos/src/bin/shooter_like.rs:210:45
|
210 | ("flat (overfit)", |mut cmd| {
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
Check warning on line 202 in demos/src/bin/shooter_like.rs
github-actions / clippy
unused variable: `cmd`
warning: unused variable: `cmd`
--> demos/src/bin/shooter_like.rs:202:43
|
202 | ("flat (exact)", |mut cmd| {
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
Check warning on line 194 in demos/src/bin/shooter_like.rs
github-actions / clippy
unused variable: `cmd`
warning: unused variable: `cmd`
--> demos/src/bin/shooter_like.rs:194:46
|
194 | ("flat (underfit)", |mut cmd| {
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
Check warning on line 188 in demos/src/bin/shooter_like.rs
github-actions / clippy
unused variable: `cmd`
warning: unused variable: `cmd`
--> demos/src/bin/shooter_like.rs:188:33
|
188 | ("no", |mut cmd| {
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 289 in demos/src/bin/platformer_3d.rs
github-actions / clippy
returning the result of a `let` binding from a block
warning: returning the result of a `let` binding from a block
--> demos/src/bin/platformer_3d.rs:289:9
|
172 | / let command_altering_selectors = CommandAlteringSelectors::default()
173 | | // By default Tnua uses a raycast, but this could be a problem if the character stands
174 | | // just past the edge while part of its body is above the platform. To solve this, we
175 | | // need to cast a shape - which is physics-engine specific. We set the shape using a
... |
269 | | },
270 | | );
| |______________- unnecessary `let` binding
...
289 | command_altering_selectors
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
172 ~
173 | #[cfg(feature = "rapier3d")]
...
190 | );
191 ~ CommandAlteringSelectors::default()
192 + // By default Tnua uses a raycast, but this could be a problem if the character stands
193 + // just past the edge while part of its body is above the platform. To solve this, we
194 + // need to cast a shape - which is physics-engine specific. We set the shape using a
195 + // component.
196 + .with_combo(
197 + "Sensor Shape",
198 + 1,
199 + &[
200 + ("no", |mut cmd| {
201 + #[cfg(feature = "rapier3d")]
202 + cmd.remove::<TnuaRapier3dSensorShape>();
203 + #[cfg(feature = "xpbd3d")]
204 + cmd.remove::<TnuaXpbd3dSensorShape>();
205 + }),
206 + ("flat (underfit)", |mut cmd| {
207 + #[cfg(feature = "rapier3d")]
208 + cmd.insert(TnuaRapier3dSensorShape(rapier::Collider::cylinder(
209 + 0.0, 0.49,
210 + )));
211 + #[cfg(feature = "xpbd3d")]
212 + cmd.insert(TnuaXpbd3dSensorShape(xpbd::Collider::cylinder(0.0, 0.49)));
213 + }),
214 + ("flat (exact)", |mut cmd| {
215 + #[cfg(feature = "rapier3d")]
216 + cmd.insert(TnuaRapier3dSensorShape(rapier::Collider::cylinder(
217 + 0.0, 0.5,
218 + )));
219 + #[cfg(feature = "xpbd3d")]
220 + cmd.insert(TnuaXpbd3dSensorShape(xpbd::Collider::cylinder(0.0, 0.5)));
221 + }),
222 + ("flat (overfit)", |mut cmd| {
223 + #[cfg(feature = "rapier3d")]
224 + cmd.insert(TnuaRapier3dSensorShape(rapier::Collider::cylinder(
225 + 0.0, 0.51,
226 + )));
227 + #[cfg(feature = "xpbd3d")]
228 + cmd.insert(TnuaXpbd3dSensorShape(xpbd::Collider::cylinder(0.0, 0.51)));
229 + }),
230 + ("ball (underfit)", |mut cmd| {
231 + #[cfg(feature = "rapier3d")]
232 + cmd.insert(TnuaRapier3dSensorShape(rapier::Collider::ball(0.49)));
233 + #[cfg(feature = "xpbd3d")]
234 + cmd.insert(TnuaXpbd3dSensorShape(xpbd::Collider::ball(0.49)));
235 + }),
236 + ("ball (exact)", |mut cmd| {
237 + #[cfg(feature = "rapier3d")]
238 + cmd.insert(TnuaRapier3dSensorShape(rapier::Collider::ball(0.5)));
239 + #[cfg(feature = "xpbd3d")]
240 + cmd.insert(TnuaXpbd3dSensorShape(xpbd::Collider::ball(0.5)));
241 + }),
242 + ],
243 + )
244 + .with_checkbox("Lock Tilt", true, |mut cmd, lock_tilt| {
245 + // Tnua will automatically apply angular impulses/forces to fix the tilt and make
246 + // the character stand upward, but it is also possible to just let the physics
247 + // engine prevent rotation (other than around the Y axis, for turning)
248 + if lock_tilt {
249 + #[cfg(feature = "rapier3d")]
250 + cmd.insert(
251 + rapier::LockedAxes::ROTATION_LOCKED_X
252 + | rapier::LockedAxes::ROTATION_LOCKED_Z,
253 + );
254 + #[cfg(feature = "xpbd3d")]
255 + cmd.insert(xpbd::LockedAxes::new().lock_rotation_x().lock_rotation_z());
256 + } else {
257 + #[cfg(feature = "rapier3d")]
258 + cmd.insert(rapier::LockedAxes::empty());
259 + #[cfg(feature = "xpbd3d")]
260 + cmd.insert(xpbd::LockedAxes::new());
261 + }
262 + })
263 + .with_checkbox(
264 + "Phase Through Collision Groups",
265 + true,
266 + |mut cmd, use_collision_groups| {
267 + #[cfg(feature = "rapier3d")]
268 + if use_collision_groups {
269 + cmd.insert(CollisionGroups {
270 + memberships: Group::GROUP_2,
271 + filters: Group::GROUP_2,
272 + });
273 + } else {
274 + cmd.insert(CollisionGroups {
275 + memberships: Group::ALL,
276 + filters: Group::ALL,
277 + });
278 + }
279 + #[cfg(feature = "xpbd3d")]
280 + {
281 + let player_layers: &[LayerNames] = if use_collision_groups {
282 + &[LayerNames::Player]
283 + } else {
284 + &[LayerNames::Player, LayerNames::PhaseThrough]
285 + };
286 + cmd.insert(CollisionLayers::new(player_layers, player_layers));
287 + }
288 + },
289 + )
|
Check warning on line 247 in demos/src/bin/platformer_3d.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> demos/src/bin/platformer_3d.rs:247:18
|
247 | |mut cmd, use_collision_groups| {
| ----^^^
| |
| help: remove this `mut`
Check warning on line 225 in demos/src/bin/platformer_3d.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> demos/src/bin/platformer_3d.rs:225:48
|
225 | .with_checkbox("Lock Tilt", true, |mut cmd, lock_tilt| {
| ----^^^
| |
| help: remove this `mut`