Fix 4586 - Make golangci-lint lint package on by default. (dense-anal…

…ysis#4730)

Checking whole packages instead of individual files is more sensible
default for golang projects. Without this we get many cryptic
`typecheck` errors in ALE that do not show when running in terminal or
CI.

ale_linters/go/golangci_lint.vim

@@ -3,7 +3,7 @@
 
 call ale#Set('go_golangci_lint_options', '')
 call ale#Set('go_golangci_lint_executable', 'golangci-lint')
-call ale#Set('go_golangci_lint_package', 0)
+call ale#Set('go_golangci_lint_package', 1)
 
 function! ale_linters#go#golangci_lint#GetCommand(buffer) abort
     let l:filename = expand('#' . a:buffer . ':t')

test/linter/test_golangci_lint.vader

@@ -14,37 +14,34 @@ After:
 Execute(The golangci-lint defaults should be correct):
   AssertLinterCwd '%s:h',
   AssertLinter 'golangci-lint',
-  \ ale#Escape('golangci-lint')
-  \   . ' run ' . ale#Escape(expand('%' . ':t'))
-  \   . ' '
+  \ ale#Escape('golangci-lint') . ' run '
 
 Execute(The golangci-lint callback should use a configured executable):
   let b:ale_go_golangci_lint_executable = 'something else'
 
   AssertLinter 'something else',
   \ ale#Escape('something else')
-  \   . ' run ' . ale#Escape(expand('%' . ':t'))
-  \   . ' '
+  \   . ' run '
 
 Execute(The golangci-lint callback should use configured options):
   let b:ale_go_golangci_lint_options = '--foobar'
 
   AssertLinter 'golangci-lint',
   \ ale#Escape('golangci-lint')
-  \   . ' run ' . ale#Escape(expand('%' . ':t'))
-  \   . ' --foobar'
+  \   . ' run '
+  \   . '--foobar'
 
 Execute(The golangci-lint callback should support environment variables):
   let b:ale_go_go111module = 'on'
 
   AssertLinter 'golangci-lint',
   \ ale#Env('GO111MODULE', 'on')
   \   . ale#Escape('golangci-lint')
-  \   . ' run ' . ale#Escape(expand('%' . ':t'))
-  \   . ' '
+  \   . ' run '
 
 Execute(The golangci-lint `lint_package` option should use the correct command):
-  let b:ale_go_golangci_lint_package = 1
-
+  let b:ale_go_golangci_lint_package = 0
   AssertLinter 'golangci-lint',
-  \ ale#Escape('golangci-lint') . ' run '
+  \ ale#Escape('golangci-lint')
+  \   . ' run ' . ale#Escape(expand('%' . ':t'))
+  \   . ' '