Add onPaste event and a flag to control the missing rows addition when pasting a data #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phen0menon
changed the title
Pull Request Test Coverage Report for Build 1279883980
💛 - Coveralls |
|
Looks good! I’m on vacation until next week so I’ll try to go around it next weekend. Thank you |
|
I found that it makes no sense to send And there is also the idea of ignoring 'readOnly' fields when pasting some values. I have implemented it locally, gonna send to review in a few days. |
iddan
reviewed
Jan 1, 2022
| @@ -70,6 +70,11 @@ export type Props<CellType extends Types.CellBase> = { | |||
| * Defaults to: `false`. | |||
| */ | |||
| hideColumnIndicators?: boolean; | |||
| /** | |||
| * If set to true, automatically creates missing rows when pasting from clipboard | |||
iddan
force-pushed
the
master
branch
2 times, most recently
from
a5442a2
to
3c0c51e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
autoPadRowsOnPasteflag which is considered to control whether the table should be extended when pasting a data out of table bounds or notAny comments are welcome.