Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding UI for comments #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DavidMunozMartinez
Copy link

@DavidMunozMartinez DavidMunozMartinez commented Oct 31, 2020

I added the UI grounds for a comment section on the ViewStoryPanel, still couldn't figure out how to get the current user name to display in the comment and i didn't touch anything back-end related.

Hope this is somehow helpful!

fixes #17

@phawazzzy
Copy link

Wow, that is nice @DavidMunozMartinez, It would be nicer if the PR is accompanied by a screenshot of the result. so we can have a view even before running the code locally

@benawad
Copy link
Contributor

benawad commented Oct 31, 2020

Nice work, I'm going to keep this PR open to see if anyone wants to pick it up and add the backend functionality

@DavidMunozMartinez
Copy link
Author

Wow, that is nice @DavidMunozMartinez, It would be nicer if the PR is accompanied by a screenshot of the result. so we can have a view even before running the code locally

I'll do you even better, have a gif frend:

ezgif com-gif-maker

@anubra266
Copy link

Woah! Nice one man

@bwanamaina
Copy link

excellente!

@DavidMunozMartinez
Copy link
Author

I assume this needs and update since the WebView is now rendered in svelt, and since I don't see people hoarding to do the backend part I think I'll give it a go myself, and give the people not what they asked for, but what they need

@benawad
Copy link
Contributor

benawad commented Nov 5, 2020

Is the ViewPanel section rendered in Svelte or the SidePanel? i still see them both as strings

@DavidMunozMartinez I forgot to push, but the code is now there. Right now, only the side panel is Svelte and it loads a script and css file that is created from compiling Svelte code:

    const scriptUri = webview.asWebviewUri(
      vscode.Uri.joinPath(this._extensionUri, "out", "compiled/bundle.js")
    );
    const styleMainUri = webview.asWebviewUri(
      vscode.Uri.joinPath(this._extensionUri, "out", "compiled/bundle.css")
    );

I'm probably going to convert the main panel to a webview again with Svelte, when I finish with that I'll let you know and comments can be added.

@DavidMunozMartinez
Copy link
Author

Got it, I'll probably work on the full stack implementation for this over the weekend

@bar9
Copy link
Collaborator

bar9 commented Nov 18, 2020

Looks promising. @DavidMunozMartinez any news on the backend?

@DavidMunozMartinez
Copy link
Author

Well, sorry, I still intend to work on it, but my personal life got very busy atm, I'll probably continue with it once I am more available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: add comments
6 participants