-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding UI for comments #21
base: master
Are you sure you want to change the base?
Conversation
Wow, that is nice @DavidMunozMartinez, It would be nicer if the PR is accompanied by a screenshot of the result. so we can have a view even before running the code locally |
Nice work, I'm going to keep this PR open to see if anyone wants to pick it up and add the backend functionality |
I'll do you even better, have a gif frend: |
Woah! Nice one man |
excellente! |
I assume this needs and update since the WebView is now rendered in svelt, and since I don't see people hoarding to do the backend part I think I'll give it a go myself, and give the people not what they asked for, but what they need |
@DavidMunozMartinez I forgot to push, but the code is now there. Right now, only the side panel is Svelte and it loads a script and css file that is created from compiling Svelte code:
I'm probably going to convert the main panel to a webview again with Svelte, when I finish with that I'll let you know and comments can be added. |
Got it, I'll probably work on the full stack implementation for this over the weekend |
Looks promising. @DavidMunozMartinez any news on the backend? |
Well, sorry, I still intend to work on it, but my personal life got very busy atm, I'll probably continue with it once I am more available |
I added the UI grounds for a comment section on the ViewStoryPanel, still couldn't figure out how to get the current user name to display in the comment and i didn't touch anything back-end related.
Hope this is somehow helpful!
fixes #17