Frame, member and project detail layout #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[add] i18n switch, LarkImage component [polish] project, member detail pages
TechQuery
requested changes
Oct 31, 2024
Comment on lines
-22
to
+27
| <div className="container mx-auto max-w-screen-xl"> | ||
| <PageHead title={t('member')} /> | ||
|
|
||
| <h1 className="my-8">{t('member')}</h1> | ||
|
|
||
| <ScrollList | ||
| translator={i18n} | ||
| store={memberStore} | ||
| renderList={allItems => <MemberListLayout defaultData={allItems} />} | ||
| defaultData={list} | ||
| /> | ||
| </div> | ||
| <Frame | ||
| title={t('member')} | ||
| header={t('member')} | ||
| store={memberStore} | ||
| Layout={MemberListLayout} | ||
| defaultData={list} | ||
| /> |
There was a problem hiding this comment.
没必要这么高度封装吧？原有三者没有必然强关联，<Frame /> 的命名也应该只包含容器、标题，而非具体内容。
There was a problem hiding this comment.
三个都是 PageHead 、h1 加 ScrollList 的结构，我可以更改命名为 FrameListLayout
There was a problem hiding this comment.
三个都是
PageHead、h1加ScrollList的结构，我可以更改命名为FrameListLayout
如果非要这样的话，命名应该是 ScrollListPage。
| export const blobURLOf = (value: TableCellValue) => | ||
| value instanceof Array | ||
| ? typeof value[0] === 'object' && ('file_token' in value[0] || 'attachmentToken' in value[0]) | ||
| ? `${fileBaseURI}/${value[0].name}` |
There was a problem hiding this comment.
R2 那个 PR 合了调通了再改，blobClient 这些都要改
Comment on lines
+46
to
49
| {/** | ||
| * @todo replace with LarkImage after R2 is ready | ||
| */} | ||
| <img className="object-fill" src={fileURLOf(project.image)} alt={String(project.name)} /> |
There was a problem hiding this comment.
R2 那个 PR 合了调通了再改，blobClient 这些都要改
There was a problem hiding this comment.
R2 那个 PR 合了调通了再改，blobClient 这些都要改
包装组件也是调用的同样的 fileURLOf()，逻辑和路径拼接是解耦的，相互不影响。
| } | ||
|
|
||
| /** | ||
| * @todo remove ScrollList and use children instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: South Drifted [email protected]
Checklist（清单）: