Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mummur: initial murmur-core and murmur-cli implementations [2][4] #5

Merged
merged 23 commits into from
Sep 30, 2024
Merged

Mummur: initial murmur-core and murmur-cli implementations [2][4] #5

merged 23 commits into from
Sep 30, 2024

Conversation

driemworks
Copy link
Contributor

@driemworks driemworks commented Sep 17, 2024 •
edited
Loading

Closes #2
Closes #4

  • separates original implementation (cli only) into cli and core repositories
  • murmur-core: implement murmurstore for constructing serializable mmr data + creating proofs + commitments
  • murmur-cli: allows ephemeral mmr wallet creation and execution
  • no_std compat
  • unit tests + coverage report

@driemworks driemworks added the do not merge this is not ready to be merged yet, so don't do it label Sep 17, 2024
@driemworks driemworks self-assigned this Sep 17, 2024
@juangirini juangirini removed the do not merge this is not ready to be merged yet, so don't do it label Sep 18, 2024
@juangirini juangirini marked this pull request as draft September 18, 2024 16:27
@driemworks driemworks marked this pull request as ready for review September 24, 2024 14:14
juangirini
juangirini requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@juangirini juangirini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the many (but trivial) requests, there are a few things that can be addressed:

  • Link task for error handling
  • Link task for zeroize
    Things that need to be done in this PR:
  • remove compile warnings
  • clippy + formatting
  • tests

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
cli/Cargo.toml Outdated Show resolved Hide resolved
core/src/otp.rs Outdated Show resolved Hide resolved
core/src/types.rs Outdated Show resolved Hide resolved
core/src/types.rs Outdated Show resolved Hide resolved
core/src/types.rs Outdated Show resolved Hide resolved
test Outdated Show resolved Hide resolved
juangirini
juangirini reviewed Sep 25, 2024
View reviewed changes
cli/src/main.rs Outdated Show resolved Hide resolved
juangirini
juangirini reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@juangirini juangirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, still a few comments from the last review not addressed

Cargo.toml Outdated Show resolved Hide resolved
cli/src/main.rs Outdated Show resolved Hide resolved
core/src/murmur.rs Outdated Show resolved Hide resolved
core/src/murmur.rs Outdated Show resolved Hide resolved
juangirini
juangirini reviewed Sep 27, 2024
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
@juangirini juangirini mentioned this pull request Sep 27, 2024
Merged
1 task
@juangirini juangirini mentioned this pull request Sep 27, 2024
Closed
@driemworks driemworks merged commit 431b7e4 into main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juangirini juangirini juangirini approved these changes

@colemanirby colemanirby colemanirby approved these changes

@carloskiron carloskiron Awaiting requested review from carloskiron

Assignees

@driemworks driemworks

Labels
None yet
Projects
Murmur
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

murmur-cli: implement create, scheduleExecute, execute murmur-core: implement create, verifyExecute, execute
3 participants
@driemworks @juangirini @colemanirby