Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to Teams Workflow #351

Merged

Conversation

FrankBlooBM
Copy link
Contributor

@FrankBlooBM FrankBlooBM commented Jul 30, 2024

Description of the Change

This PR introduces support for the new required Teams Workflow. The new webhooks need to be registered via Teams (Apps) -> Workflows -> Post to a channel when a webhook request is received.

Main changes:

  • Move from legacy MessageCard to AdaptiveCards
  • Teams Workflow webhook responds with an HTTP 202 instead of 200, and does not include a body

Benefits

  • Support the Teams Workflow
  • Exiting Teams Webhooks (going to the office endpoints) also support the new AdaptiveCards structure

Possible Drawbacks

  • Default template is change

Applicable Issues

Closes #350

Feedback on this one is much appreciated!

@xtianae7
Copy link
Member

Hello,
first of all, thank you very much for contributing, we will be reviewing the PR :) .

Could you also update the changelog?

@FrankBlooBM FrankBlooBM force-pushed the feat/support-teams-workflow branch from ab6caef to aab1a95 Compare July 31, 2024 07:33
@FrankBlooBM
Copy link
Contributor Author

Changelog is updated :) Seems that SonarCloud job fails due to a token issue?

@xtianae7 xtianae7 changed the base branch from develop to fix/350 July 31, 2024 08:27
@xtianae7 xtianae7 changed the base branch from fix/350 to develop July 31, 2024 08:55
@xtianae7
Copy link
Member

xtianae7 commented Aug 1, 2024

Hello, SonarCloud doesn't work with external PRs, thats the reason why it is failing. Don't worry :)

Copy link

@YaraGomezSaiz YaraGomezSaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtianae7 xtianae7 merged commit 846fbd7 into idealista:develop Aug 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Change Office365 Webhook to Teams Workflow