support display method; support eip165 (#213)

* add displayMethod to the credential

* use ERC165 to check interface implementation

* support type for credentialSchema

contracts/interfaces/INonMerklizedIssuer.sol

@@ -5,6 +5,23 @@ pragma solidity 0.8.16;
  * @dev INonMerklizedIssuer. Interface for non-merklized issuer
  */
 interface INonMerklizedIssuer {
+    /**
+     * @dev DisplayMethod display method for the credential
+     * Optional fields
+     */
+    struct DisplayMethod {
+        string id;
+        string _type;
+    }
+
+    /**
+     * @dev CredentialSchema. Schema for the credential
+     */
+    struct CredentialSchema {
+        string id;
+        string _type;
+    }
+
     /**
      * @dev CredentialInformation. Information about the credential
      */
@@ -13,7 +30,8 @@ interface INonMerklizedIssuer {
         string[] context;
         string _type;
         uint64 issuanceDate;
-        string credentialSchema;
+        CredentialSchema credentialSchema;
+        DisplayMethod displayMethod;
     }
 
     /**
@@ -30,10 +48,10 @@ interface INonMerklizedIssuer {
     }
 
     /**
-     * @dev listUserCredentialIds. Get list of user credentials identifiers
+     * @dev getUserCredentialIds. Get list of user credentials identifiers
      * @param _userId user id
      */
-    function listUserCredentialIds(uint256 _userId) external returns (uint256[] memory);
+    function getUserCredentialIds(uint256 _userId) external view returns (uint256[] memory);
 
     /**
      * @dev getCredential. Get credential by user id and credential id.
@@ -44,10 +62,10 @@ interface INonMerklizedIssuer {
     function getCredential(
         uint256 _userId,
         uint256 _credentialId
-    ) external returns (CredentialData memory, uint256[8] memory, SubjectField[] memory);
+    ) external view returns (CredentialData memory, uint256[8] memory, SubjectField[] memory);
 
     /**
-     * @dev getCredentialProtocolVersion. Get version of the protocol
+     * @dev getCredentialAdapterVersion. Get version of the credential adapter
      */
-    function getCredentialProtocolVersion() external returns (string memory);
+    function getCredentialAdapterVersion() external view returns (string memory);
 }

contracts/lib/NonMerklizedIssuerBase.sol

@@ -2,20 +2,31 @@
 pragma solidity 0.8.16;
 
 import {INonMerklizedIssuer} from "../interfaces/INonMerklizedIssuer.sol";
+import {IdentityBase} from "./IdentityBase.sol";
+import {ERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 
 /**
  * @dev NonMerklizedIssuerBase. Non-merklized base contract to issue non-merklized credentials
  */
-abstract contract NonMerklizedIssuerBase is INonMerklizedIssuer {
+abstract contract NonMerklizedIssuerBase is INonMerklizedIssuer, IdentityBase, ERC165 {
     /**
-     * @dev Constant representing the protocol version
+     * @dev Constant representing the credential adapter version
      */
-    string public constant CREDENTIAL_PROTOCOL_VERSION = "0.0.1";
+    string public constant CREDENTIAL_ADAPTER_VERSION = "0.0.1";
 
     /**
-     * @dev getCredentialProtocolVersion. Get version of the credential protocol
+     * @dev getCredentialAdapterVersion. Get version of the credential adapter
      */
-    function getCredentialProtocolVersion() external pure returns (string memory) {
-        return CREDENTIAL_PROTOCOL_VERSION;
+    function getCredentialAdapterVersion() external pure returns (string memory) {
+        return CREDENTIAL_ADAPTER_VERSION;
+    }
+
+    /**
+     * @dev supportsInterface. Check if the contract supports the interface
+     */
+    function supportsInterface(bytes4 interfaceId) public view virtual override returns (bool) {
+        return
+            interfaceId == type(INonMerklizedIssuer).interfaceId ||
+            super.supportsInterface(interfaceId);
     }
 }

contracts/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@iden3/contracts",
   "description": "Smart Contract library for Solidity",
-  "version": "1.4.7",
+  "version": "1.4.8",
   "files": [
     "**/*.sol",
     "/build/contracts/*.json",