Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade universal verifier #320

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Conversation

daveroga
Copy link
Contributor

@daveroga daveroga commented Nov 27, 2024

  • Fix error in getDataFromContract when upgrading Universal Verifier
  • Data from first request removed from upgrade check and created in separate function for future review
  • Get requests count and state address that is enough to check storage before and after upgrade

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12055121592

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.629%

Totals Coverage Status
Change from base Build 12034074305: 0.0%
Covered Lines: 1016
Relevant Lines: 1127

💛 - Coveralls

// {
// validatorContractAddress: contractsInfo.VALIDATOR_AUTH_V2.unifiedAddress,
// validatorContractName: contractsInfo.VALIDATOR_AUTH_V2.name,
// validatorType: VALIDATOR_TYPES.V3,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the validator type please not to have the wrong property when uncomment

@AndriianChestnykh AndriianChestnykh merged commit a430e00 into master Nov 27, 2024
5 checks passed
@AndriianChestnykh AndriianChestnykh deleted the chore/deploy-support branch November 27, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants