TS Client Implementation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rado0x54
force-pushed
the
dev-rado0x54/IDCOM-2588/ts-client
branch
from
fa76032
to
4f9cab9
Compare
Robert-H-Leonard
approved these changes
Sep 25, 2023
| public '@context'?: 'https://www.w3.org/ns/did/v1' | string | string[] = | ||
| DidDocument.defaultContext(); | ||
| public id: string; | ||
| // public alsoKnownAs?: string[]; |
There was a problem hiding this comment.
[non-blocking] Is this variable still needed?
| // Verification Method for For 20-bytes Ethereum Keys | ||
| EcdsaSecp256k1RecoveryMethod2020, | ||
| // Verification Method for a full 32 bytes Secp256k1 Verification Key | ||
| EcdsaSecp256k1VerificationKey2019, |
There was a problem hiding this comment.
The DiD registry contract only supports 20-byte ethereum keys
There was a problem hiding this comment.
Should we put that on the TODO? Generally it could support full keys, right? (The accessor just needs to convert back to a 20byte address).
| "prepack": "yarn build", | ||
| "generate-contract-types": "typechain --target=ethers-v5 --out-dir ./src/contracts/typechain-types ./src/contracts/abi/DIDRegistry.json", | ||
| "spawn-devnet": "tenderly devnet spawn-rpc --project project --template bnb-testnet", | ||
| "test:integration": "ts-mocha test/integration/**/*.test.ts" |
There was a problem hiding this comment.
I think the github workflow for running the integration test calls the command npm run integration-test it need to be updated to this new command npm run test:integration.
|
|
||
| dotenv.config(); | ||
|
|
||
| describe('Native TS Client Integration Test', () => { |
There was a problem hiding this comment.
Should there also be a test case for adding controllers?
rado0x54
force-pushed
the
dev-rado0x54/IDCOM-2588/ts-client
branch
from
b5c1a77
to
b8994ca
Compare
Provide client library @identity.com/did-bnb-client that conveniently exposes functions to interact with the on-chain EVM bases DIDRegistry contract. It comes with a thorough README and integration test that are exectuted in CI PR: #15 Signed-off-by: Martin Riedel <[email protected]> Reviewed-by: Robert Leonard <[email protected]>
rado0x54
force-pushed
the
dev-rado0x54/IDCOM-2588/ts-client
branch
from
b8994ca
to
750486c
Compare
rado0x54
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add did:bnb Typescript client library
Provide client library @identity.com/did-bnb-client that conveniently exposes functions to interact with the on-chain EVM bases DIDRegistry contract. It comes with a thorough README and integration test that are exectuted in CI
PR: #15
Signed-off-by: Martin Riedel [email protected]
Reviewed-by: Robert Leonard [email protected]