updated docs #227
Clippy (MSRV)
4 errors
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 4 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.81.0 (eeb90cda1 2024-09-04)
- cargo 1.81.0 (2dbb1af80 2024-08-20)
- clippy 0.1.81 (eeb90cd 2024-09-04)
Annotations
Check failure on line 179 in zaino-fetch/src/jsonrpc/response.rs
github-actions / Clippy (MSRV)
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> zaino-fetch/src/jsonrpc/response.rs:179:1
|
179 | impl Into<zebra_rpc::methods::GetBlockTrees> for GetBlockTrees {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-D clippy::from-over-into` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::from_over_into)]`
help: replace the `Into` implementation with `From<jsonrpc::response::GetBlockTrees>`
|
179 ~ impl From<GetBlockTrees> for zebra_rpc::methods::GetBlockTrees {
180 ~ fn from(val: GetBlockTrees) -> Self {
181 ~ zebra_rpc::methods::GetBlockTrees::new(val.sapling(), val.orchard())
|
Check failure on line 39 in zaino-fetch/src/jsonrpc/error.rs
github-actions / Clippy (MSRV)
`to_string` applied to a type that implements `Display` in `format!` args
error: `to_string` applied to a type that implements `Display` in `format!` args
--> zaino-fetch/src/jsonrpc/error.rs:39:80
|
39 | tonic::Status::internal(format!("Error: JsonRPC Client Error: {}", self.to_string()))
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `-D clippy::to-string-in-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::to_string_in_format_args)]`
Check failure on line 179 in zaino-fetch/src/jsonrpc/response.rs
github-actions / Clippy (MSRV)
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> zaino-fetch/src/jsonrpc/response.rs:179:1
|
179 | impl Into<zebra_rpc::methods::GetBlockTrees> for GetBlockTrees {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-D clippy::from-over-into` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::from_over_into)]`
help: replace the `Into` implementation with `From<jsonrpc::response::GetBlockTrees>`
|
179 ~ impl From<GetBlockTrees> for zebra_rpc::methods::GetBlockTrees {
180 ~ fn from(val: GetBlockTrees) -> Self {
181 ~ zebra_rpc::methods::GetBlockTrees::new(val.sapling(), val.orchard())
|
Check failure on line 39 in zaino-fetch/src/jsonrpc/error.rs
github-actions / Clippy (MSRV)
`to_string` applied to a type that implements `Display` in `format!` args
error: `to_string` applied to a type that implements `Display` in `format!` args
--> zaino-fetch/src/jsonrpc/error.rs:39:80
|
39 | tonic::Status::internal(format!("Error: JsonRPC Client Error: {}", self.to_string()))
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `-D clippy::to-string-in-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::to_string_in_format_args)]`