Project/good practice updates 2024 01 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnagorra
reviewed
Feb 1, 2024
puranban
force-pushed
the
project/good-practice-updates-2024-01
branch
from
4543c34
to
95fe471
Compare
tnagorra
reviewed
Feb 1, 2024
puranban
force-pushed
the
project/good-practice-updates-2024-01
branch
from
95fe471
to
576d0bf
Compare
tnagorra
requested changes
Feb 2, 2024
| <div className={styles.textLengthSection}> | ||
| {lengthExceeded && ( | ||
| {length >= textLimit && ( |
There was a problem hiding this comment.
Suggested change
| {length >= textLimit && ( | |
| {length > textLimit && ( |
|
|
||
| const handleChange = useCallback((newText: string | undefined, editor) => { | ||
| const textLength = editor.getContent({ format: 'text' }).length; | ||
| if (textLength <= sizeLimit) { | ||
| if (isDefined(textLimit) && textLength <= textLimit) { |
There was a problem hiding this comment.
Suggested change
| if (isDefined(textLimit) && textLength <= textLimit) { | |
| if (isNotDefined(textLimit) || textLength <= textLimit) { |
puranban
force-pushed
the
project/good-practice-updates-2024-01
branch
from
576d0bf
to
5acd404
Compare
tnagorra
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Depends on
Changes
This PR doesn't introduce any:
console.logmeant for debugging