forked from dhdhagar/prob-ent-resolution
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointwise features generation #2
Open
Sriharsha-hatwar
wants to merge
18
commits into
iesl:main
Choose a base branch
from
Sriharsha-hatwar:dev-aneri-shri-point-features
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pointwise features generation #2
Sriharsha-hatwar
wants to merge
18
commits into
iesl:main
from
Sriharsha-hatwar:dev-aneri-shri-point-features
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhdhagar#39) * Add --debug and --track_errors to log cvxpylayer errors * Fix save_to_wandb call for hyperparameters * Fix tensor serializable error * Fix for --eval_only_split flow * Add `sdp_scale` hyperparameter to scale the weight matrix to the SDP layer by the maximum element * Add `gradient_accumulation` hyperparameter * Change run defaults and sweep configs * Add sweep prefix option to run_sweep * Increase sweep agent memory * Clamp cvxpy output to [0,1] * Address meshgrid warning * Add `weighted_loss` to e2e sweep config * Modify run_sweep.sh to take in seed start and end values * Add `use_sdp` hyperparam to control whether to use the SDP during training and inference or directly use the MLP output with HAC-cut * Log errors before crashing; make error tracking the default behavior * Exception handling improvements * Make tqdm verbose even in silent mode * Save best dev model before testing * Add *-nosdp sweep configurations * Add `e2e_loss` hyperparam to control whether to use Frobenius or BCE loss * Change default subsampling to 80 (train) and 100 (dev) * Add --local to run with wandb disabled, change default weighted_loss to false to stay consistent with icml23 submission
… matix length and order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request contains point-wise feature code generation as a script.