Skip to content

Commit

Permalink
Add abort on missing extension type
Browse files Browse the repository at this point in the history
  • Loading branch information
wangshan committed Oct 11, 2023
1 parent 3717f63 commit 3a3d197
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions draft-wang-ppm-dap-taskprov.md
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ task ID is not recognized, then it MUST abort the upload request with

Otherwise, if the Leader does support the extension, it first attempts to parse
the "dap-taskprov" HTTP header payload. If parsing fails, it MUST abort with
"unrecognizedMessage".
"invalidMessage".

Next, it checks that the task ID indicated by the upload request matches the
task ID derived from the extension payload as specified in
Expand All @@ -389,7 +389,9 @@ The Leader then decides whether to opt in to the task as described in
> this to the Author?

Finally, once the Leader has opted in to the task, it completes the upload
request as usual.
request as usual. During the process, if Leader's report share does not present
a `task_prov` extension type, Leader SHOULD abort the upload request with
"invalidMessage".

## Aggregate Protocol

Expand Down Expand Up @@ -424,7 +426,7 @@ not recognize the task ID, it MUST abort the aggregate request with error
proceeds as follows.

First, the Helper attempts to parse payload of the "dap-taskprov" HTTP header.
If this step fails, the Helper MUST abort with "unrecognizedMessage".
If this step fails, the Helper MUST abort with "invalidMessage".

Next, the Helper checks that the task ID indicated in the upload request matches
the task ID derived from the `TaskConfig` as defined in {{construct-task-id}}.
Expand All @@ -439,7 +441,9 @@ with "invalidTask".

Finally, the Helper completes the aggregate initialize request as usual,
deriving the VDAF verification key for the task as described in
{{vdaf-verify-key}}.
{{vdaf-verify-key}}. During the process, if Helper's report share does not
present a `task_prov` extension type, Helper SHOULD abort the aggregate request
with "invalidMessage".

# Collector Behavior

Expand Down

0 comments on commit 3a3d197

Please sign in to comment.