Add back DpConfig and make vdaf_config and query_config opaque
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangshan
approved these changes
Jan 17, 2024
cjpatton
force-pushed
the
cjpastton/self-describing-2
branch
from
4292eae to
d7e5a0d
Compare
junyechen1996
approved these changes
Jan 17, 2024
kristineguo
reviewed
Jan 17, 2024
kristineguo
reviewed
Jan 17, 2024
kristineguo
reviewed
Jan 17, 2024
kristineguo
reviewed
Jan 17, 2024
kristineguo
approved these changes
Jan 17, 2024
In a previous commit f8cedf1, the `DpConfig` structure was replaced with an opaque byte string that the parties are meant to ignore. We don't want the parties to ignore unrecognized parameters: they should opt out instead. This change specifies that the content should be a `DpConfig`. We also remove the length prefix from that structure, since it's no longer needed. The same commit removed the length prefixes from `VdafConfig` and `QueryConfig`. This is a regression because it means the encoding of the `TaskConfig` is no longer self-describing. In particular, it forces to conflate opt-out due to unrecognized variants (an unimplemented VDAF, say) with serialization errors. Solve this making the `vdaf_config` and `query_config` fields of the `TaskConfig` struct opaque, in the same way that `dp_config` is opaque.
cjpatton
force-pushed
the
cjpastton/self-describing-2
branch
from
2d4c01a to
aa1815c
Compare
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option 2.
A previous commit f8cedf1, the
DpConfigstructure was replaced with an opaque byte string that the parties are meant to ignore. We don't want the parties to ignore unrecognized parameters: they should opt out instead. This change specifies that the content should be aDpConfig. We also remove the length prefix from that structure, since it's no longer needed.The same commit removed the length prefixes from
VdafConfigandQueryConfig. This is a regression because it means the encoding of theTaskConfigis no longer self-describing. In particular, it forces to conflate opt-out due to unrecognized variants (an unimplemented VDAF, say) with serialization errors. Solve this making thevdaf_configandquery_configfields of theTaskConfigstruct opaque, in the same way thatdp_configis opaque.