Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the draft into task binding and task provisioning #65

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

cjpatton
Copy link
Collaborator

Closes #54.

This commit splits the draft into the task binding extension and a separate section for the optional provisioning mechanism. While at it:

  • Fix some editorial issues.
  • Rename the extension to "Taskbind".
  • Recommend having the author digitally sign the advertised task config. This helps mitigate the risk of malicious Clients DoS'ing an Aggregator.

@cjpatton cjpatton requested a review from wangshan as a code owner June 12, 2024 23:20
Copy link
Collaborator

@wangshan wangshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a few minor comments!

draft-wang-ppm-dap-taskprov.md Outdated Show resolved Hide resolved
draft-wang-ppm-dap-taskprov.md Outdated Show resolved Hide resolved

## Task Advertisement

To advertise a task to its peer, a Taskbind participant includes a header
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Taskprov participant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This appears to be leftovers from %s/Taskprov/Taskbind/. I meant "protocol" here.

@cjpatton cjpatton requested a review from wangshan June 25, 2024 16:22
This commit splits the draft into the task binding extension and a
separate section for the optional provisioning mechanism. While at it:

- Fix some editorial issues.
- Rename the extension to "Taskbind".
- Recommend having the author digitally sign the advertised task config.
  This helps mitigate the risk of malicious Clients DoS'ing an
  Aggregator.

Co-authored-by: Shan <[email protected]>
@cjpatton
Copy link
Collaborator Author

Rebased and squashed.

@cjpatton cjpatton merged commit 8f80695 into main Jun 26, 2024
1 check passed
@cjpatton cjpatton deleted the cjpatton/54/1 branch October 3, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate transparency technique from in-line provisioning
2 participants