Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extension field to TaskConfig (*) #89

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add an extension field to TaskConfig (*) #89

merged 1 commit into from
Oct 31, 2024

Conversation

cjpatton
Copy link
Collaborator

Closes #85. We'll consider #88 (whether to remove the DP mechanism and suggest implementations do this in an extension) in a future PR.

Notable features:

  • Create a registry for new taskbind extensions
  • Make extensions mandatory-to-implement when provisioning a task

cc @martinthomson

draft-ietf-ppm-dap-taskprov.md Outdated Show resolved Hide resolved
draft-ietf-ppm-dap-taskprov.md Show resolved Hide resolved
draft-ietf-ppm-dap-taskprov.md Show resolved Hide resolved
Copy link
Collaborator

@wangshan wangshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@cjpatton consider explaining the extension code point strategy in the text (perhaps in the main DAP text and refer to it from here)

* Create a registry for new taskbind extensions

* Make extensions mandatory-to-implement when provisioning a task

Co-authored-by: Martin Thomson <[email protected]>
Co-authored-by: Shan <[email protected]>
@cjpatton
Copy link
Collaborator Author

Squashed (so that I can start stacking on this PR).

@cjpatton cjpatton mentioned this pull request Oct 30, 2024
@cjpatton cjpatton changed the title Add an extension field to TaskConfig Add an extension field to TaskConfig (*) Oct 30, 2024
@cjpatton cjpatton merged commit 2ce1766 into main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensibility
3 participants