Skip to content

Commit

Permalink
Round down the task start time when checking the report timestamp
Browse files Browse the repository at this point in the history
Aggregators are meant to reject reports with timestamps that precede the
task start time. But the Client is also supposed to round down its
timestamp, meaning it may get rejected even if upload time is valid.

To fix this, round the task start time before comparing to the report
timestamp.
  • Loading branch information
cjpatton committed Jan 14, 2025
1 parent 45a8577 commit fd4ed4c
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions draft-ietf-ppm-dap.md
Original file line number Diff line number Diff line change
Expand Up @@ -1882,9 +1882,11 @@ following checks:
`report_too_early`. Implementations may provide for some small leeway to
account for clock skew.

1. Check if the report's timestamp is before the task's `task_start` time. If
so, the Aggregator MUST mark the input share as invalid with the error
`task_not_started`.
1. Check if the report's timestamp is before the task's start time. If the
timestamp is less than `task_start - (task_start % time_precision)`, the
Aggregator MUST mark the input share as invalid with the error
`task_not_started`. Note that the task start time is rounded down since the
Client may have rounded down its timestamp as well.

1. Check if the report's timestamp is past the task's end time, given by
`task_start + task_duration`. If so, the Aggregator MUST mark the input
Expand Down

0 comments on commit fd4ed4c

Please sign in to comment.