Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API Heading to Sign-Statement #11

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

SteveLasker
Copy link
Collaborator

The current heading says: "Issue Statement", which would refer to a document the issuer is looking to create/issue. This is simply a heading change to reflect the service will Sign the Statement on their behalf, differentiating the statement as a payload.

The heading and even the API name are another discussion as the doc, as written, isn't clear if it simply returns a signed statement, the client must re-submit under /entries, or the signed-statement/issue would also register. Based on that discussion, we may want to also rename the API.

  • It's clear why the API would return the signed statement, for the client to hold and attach to a receipt.
  • It's not clear why a user would need to re-submit a signed statement, requiring multiple round trips (see Workflow and details for signed-statement/issue #10)

Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearer

@SteveLasker SteveLasker merged commit e2f23a9 into main Jun 11, 2024
2 checks passed
@SteveLasker SteveLasker deleted the steve/issue-signed-statement branch December 31, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants