Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blank.gif usage for RSS icons #1167

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Remove blank.gif usage for RSS icons #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions www/commentlog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,7 @@ if ($rss) {
echo "<h1>$title</h1>"
. "<p>This is a history of $expl."
. "<p><span class=details>View $links - "
. "<a href=\"commentlog?user=$userid&mode=$mode&rss\">"
. "<img src=\"/img/blank.gif\" class=\"rss-icon\">"
. "<a class=\"rss-icon\" href=\"commentlog?user=$userid&mode=$mode&rss\">"
. "RSS Feed of this list</a></span>";

// figure where we are in the list
Expand Down
4 changes: 2 additions & 2 deletions www/components/check-inbox.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

echo "<div class='headline check-inbox__headline'>"
. "<span class=headlineRss>"
. "<a href=\"commentlog?user=$quid&mode=inbox&rss\">"
. "<img src=\"img/blank.gif\" class=\"rss-icon\">Your Inbox (RSS)</a>"
. "<a class=\"rss-icon\" href=\"commentlog?user=$quid&mode=inbox&rss\">"
. "Your Inbox (RSS)</a>"
. "</span>"
. "Your Discussions</div>";

Expand Down
2 changes: 1 addition & 1 deletion www/home
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ if ($debugflag) echo "debug mode enabled...<br>";
<span class=headlineRss>
<a href="allnew">All Updates</a> |
<a href="news">Site News</a>
<span class='mobile-hidden'> | <a href="allnew-rss"><img src="img/blank.gif" class="rss-icon" alt="">RSS Feed</a></span>
<span class='mobile-hidden'> | <a class="rss-icon" href="allnew-rss">RSS Feed</a></span>
</span>
</div>
<div>
Expand Down
13 changes: 4 additions & 9 deletions www/ifdb.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,8 @@ with your own, you must:
b. Add an IMG definition for the class or ID of the image you wish
to replace, like so:

img.rss-icon {
a.rss-icon {
background: url("images/my-rss-icon.gif");
width: 22px;
height: 22px;
}

Note that you must specify the height and width of the image in pixels.
Expand Down Expand Up @@ -1931,12 +1929,9 @@ img.topbarcurarrow {
/*
Various icon images, used on the home page and elsewhere.
*/
img.rss-icon {
background: url("/img/rss16.gif") no-repeat center center;
width: 16px;
height: 16px;
border: none;
vertical-align: middle;
a.rss-icon {
background: url("/img/rss.svg") left 80%/1em no-repeat;
padding-left: 1.2em;
}
img.empty-button-icon {
width: 24px;
Expand Down
18 changes: 18 additions & 0 deletions www/img/rss.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed www/img/rss16.gif
View file
Open in desktop
Binary file not shown.
Binary file removed www/img/rss30.gif
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions www/news
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ echo "<h1>New Features on IFDB</h1>"
if ($item)
echo "<a href=\"news\">More site news</a> - ";

echo "<a href=\"news?rss\">"
. "<img src=\"img/blank.gif\" class=\"rss-icon\">RSS Feed</a></a></span><p>";
echo "<a href=\"news?rss\" class=\"rss-icon\">"
. "RSS Feed</a></span><p>";

// set up pagination
$perPage = 15;
Expand Down
12 changes: 5 additions & 7 deletions www/poll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,8 @@ if (isset($_REQUEST['newPollGo'])) {
. "<p>If you'd like to use your browser's RSS feature "
. "to receive updates when votes come in, here's the "
. "subscription link:<br>"
. "<a href=\"$url&rss\">"
. "<img src=\"img/blank.gif\" class=\"rss-icon\">RSS Feed</a></p>";
. "<a class=\"rss-icon\" href=\"$url&rss\">"
. "RSS Feed</a></p>";

pageFooter();
exit();
Expand Down Expand Up @@ -1119,12 +1119,10 @@ function expandVote(id)
// describe the poll
echo "<h1>$title - an IFDB Poll</h1>"
. "by <a href=\"showuser?id=$authid\">$authname</a>"
. "<br><a href=\"poll?id=$id&rss\">"
. "<img border=0 src=\"/img/blank.gif\" class=\"rss-icon\"></a> "
. "<span class=details><a href=\"poll?id=$id&rss\">"
. "RSS Feed</a></span>"
. "<br><div class=details><a class=\"rss-icon\" href=\"poll?id=$id&rss\">"
. "RSS Feed</a></div>"
. "<p>" . fixDesc($desc)
. "<p><span class=details>$commentCtl</span><p>"
. "<p><div class=details>$commentCtl</div><p>"
. (
($anonymous && $adminPriv && !isset($_REQUEST['unlock']))
? "<p><a href='poll?id=$id&unlock=1'>Admin: View all votes</a></p>"
Expand Down
4 changes: 2 additions & 2 deletions www/reviewcommentlog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,8 @@ if ($rss) {
echo "<h1>$title</h1>"
. "<p>This is a history of $expl."
. "<p><span class=details>View $links - "
. "<a href=\"reviewcommentlog?user=$userid&mode=$mode&rss\">"
. "<img src=\"/img/blank.gif\" class=\"rss-icon\">RSS Feed</a></span>";
. "<a class=\"rss-icon\" href=\"reviewcommentlog?user=$userid&mode=$mode&rss\">"
. "RSS Feed</a></span>";

// figure where we are in the list
$lastPage = (int)floor(($rowcnt + $perPage - 1)/$perPage);
Expand Down
3 changes: 1 addition & 2 deletions www/showuser
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,7 @@ if ($errMsg) {

// add the RSS feed for this member's linked games
echo "<div class='showuser__rss'><span class=details>"
. "<a href=\"showuser?id=$uid&rss=gamenews\">"
. "<img src=\"img/blank.gif\" class=\"rss-icon\">"
. "<a class=\"rss-icon\" href=\"showuser?id=$uid&rss=gamenews\">"
. "News about games authored by $username</a> (RSS Feed)</span></div>";

// check for comments
Expand Down
4 changes: 2 additions & 2 deletions www/viewcomp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ function decodeProfiles($t)
// show the page
echo "<h1>$title</h1>"
. "$desc"
. "<p><span class=details><a href=\"viewcomp?id=$compID&rss\">"
. "<img src='img/blank.gif' class='rss-icon'>News &amp; updates (RSS)</a>"
. "<p><span class=details><a class=\"rss-icon\" href=\"viewcomp?id=$compID&rss\">"
. "News &amp; updates (RSS)</a>"
. "</span>"
. "<h2>Details</h2>"
. "<div class=\"hangindentedMore notes\">";
Expand Down
12 changes: 6 additions & 6 deletions www/viewgame
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3133,12 +3133,12 @@ if (count($inrefs) != 0 && !$historyView) {
?>

<h2>RSS Feeds</h2>
<a href="viewgame?id=<?php echo $id ?>&reviews&rss">
<img src="img/blank.gif" class="rss-icon">New member reviews</a>
<br><a href="viewgame?id=<?php echo $id ?>&downloads&rss">
<img src="img/blank.gif" class="rss-icon">Updates to external links</a>
<br><a href="viewgame?id=<?php echo $id ?>&news&rss">
<img src="img/blank.gif" class="rss-icon">All updates to this page</a>
<a class="rss-icon" href="viewgame?id=<?php echo $id ?>&reviews&rss">
New member reviews</a>
<br><a class="rss-icon" href="viewgame?id=<?php echo $id ?>&downloads&rss">
Updates to external links</a>
<br><a class="rss-icon" href="viewgame?id=<?php echo $id ?>&news&rss">
All updates to this page</a>

<?php

Expand Down