Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search page cleanup #1175

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

salty-horse
Copy link
Collaborator

@salty-horse salty-horse commented Nov 23, 2024

  • This touches other pages, too: Use <aside> for tipboxes, add a title to the 'create style' tipbox
  • Remove duplication in search URL query parsing - the two loops set the same variables, so I removed the duplication, and turned the map into a const.
  • Fix undefined variable in /search?game - In helpExtLink(), I think this was a copy-paste error from helpListLink() that needs the $id to expand the section when clicking it.
  • Remove unused newSearch function - it was removed in d818146
  • Move search form into a function - I think I got everything right. The search box in the bottom sets an id, but it's unused. For some reason, the game search form included all the help text, and I don't think there was any hidden input element there, so I moved it outside, and unindented it (View the commit with "ignore whitespace" to see the actual changes)

www/search Outdated Show resolved Hide resolved
@salty-horse
Copy link
Collaborator Author

Renamed to SEARCH_TYPES. Once again, I force-pushed and reflexively rebased onto the latest main, so the "Compare" button offered by Github will show more changes than intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants