Fix incorrect return type in Walker.normalize_ast #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Solargraph 0.51.0, I started hitting exceptions from walker.rb like this: ``` [WARN] wrong number of arguments (given 3, expected 1..2) .../solargraph-rails/lib/solargraph/rails/walker.rb:78:in `initialize' /Users/broz/src/solargraph-rails/lib/solargraph/rails/walker.rb:67:in `new' /Users/broz/src/solargraph-rails/lib/solargraph/rails/walker.rb:67:in `from_source' /Users/broz/src/solargraph-rails/lib/solargraph/rails/model.rb:15:in `process' /Users/broz/src/solargraph-rails/lib/solargraph-rails.rb:48:in `block in local' /Users/broz/src/solargraph-rails/lib/solargraph-rails.rb:61:in `run_feature' /Users/broz/src/solargraph-rails/lib/solargraph-rails.rb:48:in `local' /Users/broz/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/solargraph-0.51.0/lib/solargraph/convention.rb:28:in `block in for_local' /Users/broz/.rbenv/versions/3.1.6/lib/ruby/3.1.0/set.rb:511:in `each_key' /Users/broz/.rbenv/versions/3.1.6/lib/ruby/3.1.0/set.rb:511:in `each' /Users/broz/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/solargraph-0.51.0/lib/solargraph/convention.rb:27:in `for_local' /Users/broz/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/solargraph-0.51.0/lib/solargraph/source_map.rb:32:in `initialize' /Users/broz/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/solargraph-0.51.0/lib/solargraph/source_map.rb:158:in `new' /Users/broz/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/solargraph-0.51.0/lib/solargraph/source_map.rb:158:in `map' /Users/broz/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/solargraph-0.51.0/lib/solargraph/api_map.rb:54:in `map' /Users/broz/src/solargraph-rails/spec/helpers.rb:4:in `load_string' /Users/broz/src/solargraph-rails/spec/solargraph-rails/model_spec.rb:80:in `block (3 levels) in <top (required)>' ``` It looks like it happens in cases where Solargraph's source.node is a ::Parser::AST::Node. There's a special case in Walker.normalize_ast() that is triggering that does not look correct on its face - it should always return an array of nodes, since the result is splatted in Walker.from_source. The spec added reproduces this in newer solargraphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Solargraph 0.51.0, I started hitting exceptions from walker.rb like this:
It looks like it happens in cases where Solargraph's source.node is a ::Parser::AST::Node. There's a special case in Walker.normalize_ast() that is triggering that does not look correct on its face - it should always return an array of nodes, since the result is splatted in Walker.from_source.
The spec added reproduces this in newer solargraphs.