Fix typo circunous -> circonus

fix a memory leak bug for mset command

Support for these was introduced in
@4175419288ef66d95e082cfa2124e77fe6d4fe6d.

Update redis docs for PING and QUIT

Added Greta to the list of companys

Update the sensu-metrics link

Update README.md

Fix typo in notes/memcache.md

fix typo in README.md

It seems like field->perm might be uninitialized memory
depending on how it is allocated.

I ran into an issue where different sockets had different file
permissions, and some of those sockets weren't readable by the user
which created it.

This behavior probably started in
https://github.com/twitter/twemproxy/pull/311/files

…licies

Adding issue and pull request templates to comply with twitter OSS best practices.

allow spop can parameters

Fix indented bulleted list and add monospaced formatting to command flags within paragraphs

Add Docker support

Fix README typo

This detects some inconsistent uses of indentation and inconsistent
space after casts, but has a lot more false positives.

https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting
may be of use for saving time for contributors reformatting new patches

Plugins for editors/IDEs exist that can enforce some of these rules

Add editorconfig matching the c style guide, fix typos in c style guide

Running it in docker makes it easier to run this in other CI providers
and to easily reproduce any failures seen in Travis locally.

Move to python 3

This is useful if the tests hang due to a change.
Otherwise, log capturing would prevent you from seeing the logs.

Run in multiple redis versions

Update some unit tests and reorganize docker build steps

Fix failing unit tests, run in Docker

If hostnames are used instead of ip addresses for all hosts within a pool,
and dns lookup fails, then get/multiget  will hang indefinitely **instead of**
responding with an error such as `SERVER_ERROR Host is down`.
(I expect a client would detect this and close the connection,
but this is not ideal, the client timeout could be a second)

- Both redis and memcache protocols are affected
- If a server resolves but is down, then `get` does respond with `SERVER_ERROR Host is down`.

I suspect that's because memcached get is implemented to coalesce responses
from multiple backend servers, even when there's only one key,
and this is likely a bug specific to handling coalescing when
there's no attempt to send the request to a backend server

Because connection attempts are async but dns lookup is asynchronous,
there's a non-null server connection for a host that's unavailable
but a null server connection for a host that has a dns lookup error,
and these end up using different code paths.
(e.g. the former will call server_close() which does adjust nfrag_sent)

Fixes twitter#596

Travis CI builds have been queueing for hours for some builds.
This a simple docker script.

…ions

Switch to GitHub actions for builds

…erance

Don't hang for dns error responding to fragmented requests

Add a clang-format file approximating the c style guide

ncontinuum is `160 * the number of **non-ejected** hosts` for the ketama
distribution, where 160 is the ketama consistent hashing points per server.
However, the index returned by msg_backend_idx is a number between
0..nservers-1.

- This is a waste of time zeroing out 160 times as much memory as needed
- When there are 0 servers, this previously malloc()ed a pointer of size 0 bytes
  and nutcracker would write to invalid memory.

Also, update redis nosetest expectation because newer redis versions changed the
error message to mention replica instead.

Fixes twitter#563 for redis and memcached.
See the discussion there for more details.

Fragmentation would likely be slower.
It would involve splitting up the request into multiple smaller
requests (allocating and zeroing out an array)
and concatenating strings to rebuild the original request.

Fragmentation is also more likely to be prone to edge cases such as
those mentioned in twitter#597
and twitter#595

…-of-ncontinuum

Use nservers instead of ncontinuum to fix segfault when all hosts are ejected

Always initialize file permissions field for unix domain socket

…len and make sure hostlen is equal or less than KETAMA_MAX_HOSTLEN

Amended version of twitter#567

Amended to remove the trailing null byte when logging
if this does truncate, which shouldn't happen in practice

Co-Authored-By: Tyson Andre <[email protected]>
Co-Authored-By: 李广博 <[email protected]>

Add a `make check` script with standalone unit tests of the c functions.
Source: https://github.com/ifwe/twemproxy/tree/build-nutredis

This is the subset of the tests that currently pass in
twitter/twemproxy

Add various unit tests and integration tests

And add unit tests of redis messages being parsed successfully

Fix parsing of redis error message without space

If this is approved, documentation should also be added to
notes/redis.md

Some commands such as EXISTS have been changed to support multiple
arguments.

Copied from https://github.com/ifwe/twemproxy/pull/32/files
which also updates unit tests (depends on changes to the test framework)
- That PR has the script used to extract updated argument counts from
  redis-doc's commands.json file
- See twitter#598 for fixing tests

Related to https://github.com/twitter/twemproxy/pull/589/files

nutredis currently only supports keys for sharding in the first position.
That can be fixed but using `operation` is wrong

Leave more complicated implementations for subsequent PRs

Support various commands from newer redis versions

i.e. the response of georadiuswithcoord.
This is achieved by introducing a small stack in struct msg,
this stack remembers the number of arguments to be parsed of current multibulk
and all nesting multibulks.

Co-Authored-By: qingping209 <[email protected]>
Co-Authored-By: Tyson Andre <[email protected]>

This is a subset of twitter#565
(only the multibulk implementation changes by qingping209)

This amends the approach originally proposed in
twitter#565

We don't need to keep a stack, we only need to keep track
of how many more remaining elements need to be parsed from the redis
response, decreasing it when an element is processed,
and increasing it when a new redis array is seen based on the array length

Fix processing of redis multibulk (nested array) responses (from eval, new commands, etc)

Revert the addition of blocking commands - making them a compilation
option is probably a poor way to distribute it.

Support `COMMAND` (used by redis-cli) and a placeholder no-argument command
forwarded to a random server.

…mmands-followup

Followup for new redis commands and multibulk support

The size of the difference between two pointers
depends on the platform (e.g. 64bit vs 32bit pointers),
so cast it to an integer - it should fit in that range anyway.

Closes twitter#614

Fail GitHub actions builds on new compiler warnings, warn about incorrect log format strings

This uses commands.json from redis's documentation to determine which
category a given redis command falls into.
This will be useful to ensure that twemproxy stays up to date with new redis
commands.

…gcounts

[skip ci] Add script to extract redis key/arg count ranges

The recent patches add support for a placeholder key, which is actually
a constant string in memory.

The logging helper method should not be mutating the data it's logging.
Specify the length of the string to log instead of introducing a null
byte.

Fix a crash seen when logging redis `COMMAND` in recent patches

fix list indentation in README

https://github.com/linsomniac/python-memcached/ 1.5.8
had the delete_multi signature fixed in 2016.
Anyone who had installed an outdated version should have
seen this recommendation already or worked around it differently.

There are a large number of other languages that have their own memcache
clients with different bugs, don't continue linking to the workaround
for an outdated python-memcached client version

Closes twitter#475

[skip ci] Remove reference to outdated python-memcached version

Improve formatting of README file

Update tests

Add const value qualifiers for C functions where applicable

…twitter-v2

Conflicts:
	.dockerignore
	.github/workflows/main.yml
	.travis.yml
	ChangeLog
	README.md
	ci/build-nutcracker.sh
	src/Makefile.am
	src/hashkit/nc_hashkit.h
	src/nc_connection.c
	src/nc_mbuf.c
	src/nc_message.c
	src/nc_message.h
	src/nc_request.c
	src/nc_server.c
	src/proto/nc_memcache.c
	src/proto/nc_proto.h
	src/proto/nc_redis.c
	src/test_all.c
	tests/test_redis/test_basic.py
	travis.sh

…twitter-v2