Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix can't resolve rebar version problem; fix sdk string mismatching #926

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yidayoung
Copy link
Contributor


fix #903
like issue said can't resolve rebar version problem on windows, seems just should use escript.getStdOut() not rebar.getStdOut()

ExtProcessUtil.ExtProcessOutput escript = ExtProcessUtil.execAndGetFirstLine(3000, escriptPath, rebarPath, "--version");
String versionWithEscript = rebar.getStdOut();


after this comit 0dfb40e[simplify visible erlang sdk name]
should also change patten

private static final Pattern VERSION_PATTERN = Pattern.compile("Erlang/OTP (\\S+) \\[erts-(\\S+)]");

public String toString() {
return "OTP " + getOtpRelease() + ", erts-" + getErtsVersion();

or ErlangSdkType.detectSdkVersion will always call erl, but not all time can use OSProcessHandler, it will make error ERROR - ution.process.OSProcessHandler - Synchronous execution on EDT

fix sdk string mismatching
@kvakvs
Copy link
Collaborator

kvakvs commented Nov 16, 2022

OTP version can be read from SdkRoot/releases/xx/OTP_VERSION and ERTS version can be found from SdkRoot/erts-xxx directory name. I will soon create a merge request for that and also will look at this code here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't check rebar version
2 participants