feat: add version and cobra command #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
julienrbrt
requested changes
Nov 22, 2024
julienrbrt
reviewed
Nov 22, 2024
| "github.com/ignite/cli/v28/ignite/pkg/xexec" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
I know this comes from CLI but isn't it a bit oferkill? We should just display the tag or devel imho using runtime BuildInfo
There was a problem hiding this comment.
I like it because we can get user info and debug the issues easier. We can always ask: type faucet version and paste it here
Yes, that is true. I think we should keep only this repo now. I can do it in another PR, because it will be huge |
julienrbrt
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.