Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add build script for Gex #11

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

Ehsan-saradar
Copy link
Contributor

No description provided.

@Ehsan-saradar Ehsan-saradar changed the title Add build script for Gex feat: Add build script for Gex Oct 9, 2023
scripts/build-gex Outdated Show resolved Hide resolved
Copy link
Member

@jeronimoalbi jeronimoalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually would be a good improvement to use Gex as a Go dependency instead of a binary

@Ehsan-saradar
Copy link
Contributor Author

Eventually would be a good improvement to use Gex as a Go dependency instead of a binary

This we can not do because with the current code base there's only a main.go file which obviously we can't import.

@Pantani
Copy link
Collaborator

Pantani commented Oct 13, 2023

@Ehsan-saradar, Can you also create a GitHub pipeline to update the binaries eventually in case we have a new one? Like the nodetime

@Ehsan-saradar
Copy link
Contributor Author

@Ehsan-saradar, Can you also create a GitHub pipeline to update the binaries eventually in case we have a new one? Like the nodetime

Good suggestion, i changed the script and added a workflow file like the one for nodetime. could you double check and see if everything is done correctly?

@Pantani Pantani requested a review from jeronimoalbi October 17, 2023 10:44
@Pantani Pantani merged commit 298d0f1 into main Oct 18, 2023
2 checks passed
@Pantani Pantani deleted the feat/add-build-scripts-for-gex branch March 12, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants