When clustering is used, solves the problem of not joining the room

[abdurrahmanekr]

Hello, when using bosh with Openfire cluster, could not join the MUC rooms. This PR for controlling occupantsByNickname and occupantsByFullJID variables.

openfire-cluster-behaves-unexpectedly-on-the-muc

[IgniteRealtime-Bot]

This pull request has been mentioned on Ignite Realtime Community Forums. There might be relevant details there:

https://discourse.igniterealtime.org/t/openfire-cluster-behaves-unexpectedly-on-the-muc/86520/10

[speedy01]

@GregDThomas @guusdk please review! Thanks

[GregDThomas]

I'm not sure I can add anything useful to this.

But that doesn't normally stop me, so:

The Discourse thread seems to indicate that this only happens with BOSH (possibly also WebSocket?) connections, not TCP connections.

Suggest to me that whilst the code fixes the underlying problem of a NPE, the fix is actually masking some issue with the BOSH connectivity.

[akrherz]

@abdurrahmanekr , sorry this PR has languished. Are you able to rebase it?

[abdurrahmanekr]

Hi @akrherz, when I look at the last changes, I see that the same logic is used. That's why I tried to write the same code while solving the conflict. As mentioned in discouse, I had this problem only when using BOSH (http-bind). We are currently using this code in our system and I have to compile openfire's core accordingly. Because people can't join groups while using bosh (with cluster).

[Fishbowler]

Given how long this has languished, and that the simple change no longer applies on the tip of main, should we close this?

I think perhaps implied by:

when I look at the last changes, I see that the same logic is used

... this is already done?