Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-2831: Modify tests to cover offending data #2670

Merged

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Feb 6, 2025

This modifies existing unit tests to explicitly use data that appears to have triggered OF-2831. The resulting tests do not fail.

This modifies existing unit tests to explicitly use data that appears to have triggered OF-2831. The resulting tests do not fail.
@akrherz akrherz added the backport 4.9 on merge, GHA will generate a PR with these changes against 4.9 branch label Feb 6, 2025
@akrherz akrherz merged commit 2e2c72d into igniterealtime:main Feb 6, 2025
15 checks passed
Copy link

github-actions bot commented Feb 6, 2025

Backport failed for 4.9, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 4.9
git worktree add -d .worktree/backport-2670-to-4.9 origin/4.9
cd .worktree/backport-2670-to-4.9
git switch --create backport-2670-to-4.9
git cherry-pick -x 3c479256c70b194297659750659e267fc7c47d5b

@guusdk
Copy link
Member Author

guusdk commented Feb 6, 2025

Maybe not bother with the backport if that conflicts?

@akrherz
Copy link
Member

akrherz commented Feb 6, 2025

Maybe not bother with the backport if that conflicts?

I was curious if this issue would reproduce on the 4.9 branch. It is a simple patch, I'll manually effort now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.9 on merge, GHA will generate a PR with these changes against 4.9 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants