OF-2793: Bundle an Oracle database driver #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given changes in the Oracle license, we can now bundle their database drivers with Openfire. The changes in this commit do just that. I've opted to use ojdbc11-production rather than ojdbc17-production as the latter is documented to be compatible with Jakarta. We do not use Jakarta. ojdbc11 has been documented to be compatible with Java 17 and 21, which should be good enough for us for now. Jetty's JSP compiler plugin is not happy with the standard Oracle dependencies. It fails on expecting but not finding oracle.i18n.util.LocaleMapper. The internet suggests that this is caused by Oracle's xmlparserv2 dependency. Excluding that 'fixes' the problem. I'm not sure what functionality this affects. As a side-effect, the `lib` folder of a distribution now contains an unneeded POM file. I can't find an easy way to exclude that.
Fishbowler
reviewed
Feb 6, 2025
Fishbowler
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given changes in the Oracle license, we can now bundle their database drivers with Openfire. The changes in this commit do just that.
I've opted to use ojdbc11-production rather than ojdbc17-production as the latter is documented to be compatible with Jakarta. We do not use Jakarta. ojdbc11 has been documented to be compatible with Java 17 and 21, which should be good enough for us for now.
Jetty's JSP compiler plugin is not happy with the standard Oracle dependencies. It fails on expecting but not finding oracle.i18n.util.LocaleMapper. The internet suggests that this is caused by Oracle's xmlparserv2 dependency. Excluding that 'fixes' the problem. I'm not sure what functionality this affects.
As a side-effect, the
libfolder of a distribution now contains an unneeded POM file. I can't find an easy way to exclude that.