Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: import bdist_wheel from setuptools #810

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

m1-s
Copy link
Contributor

@m1-s m1-s commented Dec 22, 2024

This PR removes the direct dependency from wheel and imports bdist_wheel from setuptools instead. This change is motivated by pypa/setuptools#4647.

Other libs have done similar changes as this PR https://github.com/yaml/pyyaml/pull/823/files.

Disclaimer: I am not a python developer. I am just trying to fix a piece of software that depends on igraph and broke when being built in an environment with more recent dependency versions.

@m1-s m1-s force-pushed the removeWheelImport branch from 2ef341f to 023af84 Compare December 22, 2024 18:48
@ntamas
Copy link
Member

ntamas commented Dec 23, 2024

CI failure above is most likely unrelated to this change so I'll just merge and try to fix the CI failure in main. Thanks a lot!

@ntamas ntamas merged commit 618e46a into igraph:main Dec 23, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants