feat: simple_cycles() lists all simple cycles
#1580
Draft
+130
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps We can model this on |
szhorvat
force-pushed
the
feat/simple_cycles
branch
from
245f000 to
3528646
Compare
|
Refactored to use It would be useful not to prevent running checks when the base branch is not |
szhorvat
force-pushed
the
feat/simple_cycles
branch
from
3528646 to
e63943b
Compare
|
@krlmlr why is a review by @Antonov548 needed? After that review, I can work on the tests. |
The idea was just to take a look active pull requests to still keep up to date what is changing. |
krlmlr
requested changes
Jan 5, 2025
| @@ -3580,25 +3580,6 @@ find_cycle_impl <- function(graph, mode=c("out", "in", "all", "total")) { | |||
| res | |||
| } | |||
|
|
|||
| simple_cycles_impl <- function(graph, mode=c("out", "in", "all", "total"), min.cycle.length=-1, max.cycle.length=-1) { | |||
There was a problem hiding this comment.
Do you see a downside in keeping this and making simple_cycles() a wrapper of this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #1567 and #1571. For now, it targets the
simple_cycles-base-branchbranch, which has those PRs merged. Once they are merged tomain, it should be marked as ready-for-review and re-targeted.Can you please help me implement tests @maelle ? What I'd like to have a is a check on the cycle length histograms for the graph already added to the examples. Count cycles of length 1, length 2, etc. and add a check on the expected numbers. I'm not sure what's the best way to do this in R.
Closes #1573