Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pool_pre_ping to engine creation options #103

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

meksor
Copy link
Contributor

@meksor meksor commented Jul 31, 2024

Another stab at the postgres connection timeout problem! This is kind of a hack but pool_pre_ping sends a "ping query" up to three times before trying the actual query, should help with our idle-connection problem at a small cost until this is figured out on the setup side.
https://docs.sqlalchemy.org/en/20/core/engines.html#sqlalchemy.create_engine.params.pool_pre_ping

Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

What does it mean, though: "until this is figured out on the setup side"? Should ICT do something? Do we need a tracking issue for this?

@meksor meksor merged commit fa14396 into main Jul 31, 2024
9 checks passed
@meksor meksor deleted the bugfix/preping-pool branch July 31, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants