Fix list() and tabulate() for existing optimization items with specific run-request
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glatterf42
changed the title
list() and tabulate() for optimization items with specific run-requestlist() and tabulate() for existing optimization items with specific run-request
glatterf42
force-pushed
the
fix/list-tabulate-optimization-run
branch
from
7a93073 to
35ec82d
Compare
There was a problem hiding this comment.
Thanks @glatterf42, good catch! I made a few comments on streamlining the tests for the indexsets, does also apply to the other types...
danielhuppmann
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also while working on the GAMS transport tutorial, I discovered that all optimization items had inconsistent behavior in the facade layer:
run.optimization.scalar.tabulate()would list all scalars of all runs, while...list()would list only those of the run the scalars belong to. The latter is clearly desired, so this PR fixes the inconsistency and adds tests to confirm.Since
Parameter,Equation, andVariablehave not yet landed on main, I'll include corresponding changes in their pending PRs.