Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize IndexSet.data DB storage #122

Merged
merged 12 commits into from
Nov 22, 2024
Merged

Normalize IndexSet.data DB storage #122

merged 12 commits into from
Nov 22, 2024

Commits on Oct 21, 2024

  1. Add new DB data types and imports

    @glatterf42
    glatterf42 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4e9bc8e View commit details
    Browse the repository at this point in the history

  2. Refactor indexset.add_data() 

    * Introduce new IndexSetData table to normalize data
* Rename .elements to .add for consistency
    @glatterf42
    glatterf42 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6e51100 View commit details
    Browse the repository at this point in the history

  3. Adapt tests to refactoring

    @glatterf42
    glatterf42 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    24a1181 View commit details
    Browse the repository at this point in the history

  4. Adapt foreign mentions of indexset.data

    @glatterf42
    glatterf42 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4234042 View commit details
    Browse the repository at this point in the history

  5. Fix references to add_elements

    @glatterf42
    glatterf42 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4bbd26a View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Cast types using numpy for efficiency

    @glatterf42
    glatterf42 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    52f3423 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Reduce number of lines needing tests

    @glatterf42
    glatterf42 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2b62ae7 View commit details
    Browse the repository at this point in the history

  2. Address review comments 

    * Make data loading during tabulate() optional
* Use bulk insert for IndexSetData
* Use a normal property for `.data`
    @glatterf42
    glatterf42 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a7246cd View commit details
    Browse the repository at this point in the history

  3. Remove not-required parameter

    @glatterf42
    glatterf42 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    03f75c2 View commit details
    Browse the repository at this point in the history

  4. TEMPORARY Add all missing db migrations

    @glatterf42
    glatterf42 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    827a1b8 View commit details
    Browse the repository at this point in the history

  5. Reconcile alembic migrations

    @glatterf42
    glatterf42 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ef5616d View commit details
    Browse the repository at this point in the history

  6. Record changes in DB migration

    @glatterf42
    glatterf42 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    85dc134 View commit details
    Browse the repository at this point in the history