Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show audit info in runs.tabulate() #128

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Show audit info in runs.tabulate() #128

merged 3 commits into from
Oct 24, 2024

Conversation

danielhuppmann
Copy link
Member

This PR adds an audit-info option to runs.tabulate() to show some extra columns.

@danielhuppmann danielhuppmann self-assigned this Oct 24, 2024
@danielhuppmann danielhuppmann requested a review from meksor October 24, 2024 11:54
meksor
meksor approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@meksor meksor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, noting that I don't recall if this is working for list yet

@danielhuppmann
Copy link
Member Author

FWIW, the Platform.runs.list() returns a list of instances, so it's more an issue that the audit-info is not accessible via the Run class at the facade layer (and neither is the current default-status, it seems, only methods to set or unset).

@danielhuppmann danielhuppmann merged commit b982f47 into iiasa:main Oct 24, 2024
12 checks passed
@danielhuppmann danielhuppmann deleted the runs/audit branch October 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meksor meksor meksor approved these changes

Assignees

@danielhuppmann danielhuppmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielhuppmann @meksor