Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace resolved numpy workaround with dask workaround #886

Closed
wants to merge 1 commit into from

Conversation

glatterf42
Copy link
Member

This PR tries to resolve the CI test failures by not using version 2024.11.0 of dask, which is causing issues with genno.

The most preferable solution would be to adapt genno to this dask version, but it is unclear how much effort this would be and how long this would take. So for now, I'm simply imposing that we don't use that particular version (note: 2024.11.1 would be allowed, hoping that this might resolve the incompatibilities).
If this workaround is successful and we agree we want to employ it for now, we should also adopt it in the nightly workflow.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Update CI tests; coverage checks both ✅
  • [ ] Add, expand, or update documentation. Just CI.
  • [ ] Update release notes. Just CI.

@glatterf42 glatterf42 added the ci Continuous integration label Nov 11, 2024
@glatterf42 glatterf42 self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.5%. Comparing base (9d9f5bd) to head (7c4d4aa).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #886     +/-   ##
=======================================
- Coverage   95.5%   95.5%   -0.1%     
=======================================
  Files         46      46             
  Lines       4340    4340             
=======================================
- Hits        4148    4145      -3     
- Misses       192     195      +3     

see 2 files with indirect coverage changes

@glatterf42
Copy link
Member Author

Superseded by #887. Apparently, GitHub will not simply execute a workflow file from a fork, which seems reasonable.

@glatterf42 glatterf42 closed this Nov 11, 2024
@glatterf42 glatterf42 deleted the fix/CI-dask-numpy branch November 11, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant