-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs with links and a new paper #888
Open
glatterf42
wants to merge
4
commits into
iiasa:main
Choose a base branch
from
glatterf42:update/docs/bib-community-health
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update docs with links and a new paper #888
glatterf42
wants to merge
4
commits into
iiasa:main
from
glatterf42:update/docs/bib-community-health
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
=====================================
Coverage 95.5% 95.5%
=====================================
Files 46 46
Lines 4340 4340
=====================================
Hits 4148 4148
Misses 192 192 |
glatterf42
force-pushed
the
update/docs/bib-community-health
branch
from
November 13, 2024 13:44
fac4740
to
1653084
Compare
Hi Fridolin,
Nice to hear from you.
I'm sending attached some suggestions of images. Please feel free to use
the most suitable one.
Here is the link for the paper:
https://www.sciencedirect.com/science/article/pii/S2352152X2400834X#f0010
Let me know if you need any extra info.
Best,
Natalia
[image: SPHS.jpg][image: BESSM model overview.jpg][image: BESSM
model.jpg][image:
Methodology.jpg]
…On Wed, Nov 13, 2024 at 2:38 PM Fridolin Glatter ***@***.***> wrote:
Thanks to @shreeyashn20 <https://github.com/shreeyashn20> in #883
<#883>, I have been made
aware of the paper
<https://www.sciencedirect.com/science/article/pii/S2352152X2400834X> by
@natiweber <https://github.com/natiweber> about the Brazilian energy
model with seasonal pumped hydropower storage. This PR adds a link to that
to the docs.
It also links our new community health files from our contributing page.
@natiweber <https://github.com/natiweber> or @behnam-zakeri
<https://github.com/behnam-zakeri> (since you are a co-author): we
usually use a preview image for the entries on our usage page. Please let
me know if you have an image in mind that we can use for that :)
How to review
- Read the diff and note that the CI checks all pass.
- Look at the pages in the docs that changed and confirm they look
good:
- TBD
PR checklist
- Continuous integration checks all ✅
- [ ] Add or expand tests; coverage checks both ✅ Just updating docs.
- Add, expand, or update documentation.
- [ ] Update release notes. Just updating docs.
------------------------------
You can view, comment on, or merge this pull request online at:
#888
Commit Summary
- 827accf
<827accf>
Add new paper to bibliography
- c50d010
<c50d010>
Add paragraph about new paper to docs
- fac4740
<fac4740>
Add links to community health files to contributing page
File Changes
(3 files <https://github.com/iiasa/message_ix/pull/888/files>)
- *M* doc/contributing.rst
<https://github.com/iiasa/message_ix/pull/888/files#diff-13795c17121ec235cc0d7a1f5df177f3a5af2e32d2cbd2d95c8b020ad8c76516>
(5)
- *M* doc/references.bib
<https://github.com/iiasa/message_ix/pull/888/files#diff-377b988b90a7f40ae57540205224bac7050f568f9a76c518e20e76e899134655>
(14)
- *M* doc/usage.rst
<https://github.com/iiasa/message_ix/pull/888/files#diff-e2f32bf1fe37315337b25b0d5efe2a8dde59b0f5ea2c3d6fddcf3f8b6d0fe9d1>
(15)
Patch Links:
- https://github.com/iiasa/message_ix/pull/888.patch
- https://github.com/iiasa/message_ix/pull/888.diff
—
Reply to this email directly, view it on GitHub
<#888>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANUUQ37UKOLR2FMRX4UYLQT2ANI5FAVCNFSM6AAAAABRWQNS2WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TKNJVGY3DINQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Natalia Weber, Dr. Ing.*
Mentoring Programme Coordinator
📞 +43 676 551 3831
🌐 LinkedIn <http://www.linkedin.com/in/natalia-ab-weber>
|
glatterf42
force-pushed
the
update/docs/bib-community-health
branch
from
November 18, 2024 07:20
1653084
to
0d65d2d
Compare
Thanks for the suggestions, let's see how we like the one I used now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @shreeyashn20 in #883, I have been made aware of the paper by @natiweber about the Brazilian energy model with seasonal pumped hydropower storage. This PR adds a link to that to the docs.
It also links our new community health files from our contributing page.
@natiweber or @behnam-zakeri (since you are a co-author): we usually use a preview image for the entries on our usage page. Please let me know if you have an image in mind that we can use for that :)
How to review
PR checklist
[ ] Add or expand tests; coverage checks both ✅Just updating docs.[ ] Update release notes.Just updating docs.